Closed Bug 1485956 Opened Last year Closed Last year

make DNS cache lookups differ between TRR and non-TRR

Categories

(Core :: Networking: DNS, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bagder, Assigned: bagder)

References

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

An entry that ends up in the cache when TRR is allowed will not be re-used if the same host name is resolved again with TRR-disabled.

This way, a host name resolved with TRR that is cached will not be returned for a subsequent resolve with TRR explicitly *disabled*.
Component: Framework → Networking: DNS
Product: DevTools → Core
To keep in mind:

1 - a regular non-TRR lookup should not do a second resolve on disable-TRR set

2 - a regular mode-2 TRR should still re-use the regular cache entries as long as disable-TRR is not set
So that explicitly disabling TRR for specific resolves won't end up just
using the cached entry resolved with TRR!

MozReview-Commit-ID: HZ4AyKOMpet
Comment on attachment 9003788 [details]
bug 1485956 - make DNS cache lookups respect DISABLE_TRR

Valentin Gosu [:valentin] has approved the revision.
Attachment #9003788 - Flags: review+
Pushed by daniel@haxx.se:
https://hg.mozilla.org/integration/autoland/rev/9f1b27308bd6
make DNS cache lookups respect DISABLE_TRR r=valentin
https://hg.mozilla.org/mozilla-central/rev/9f1b27308bd6
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1487432
You need to log in before you can comment on or make changes to this bug.