Closed Bug 1486074 Opened 7 years ago Closed 7 years ago

Fields of -moz-column-span are not defined in property_database.js

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

In my try run [1] to enable "layout.css.column-span.enabled", I notice the following error. TEST-UNEXPECTED-FAIL | layout/style/test/test_ch_ex_no_infloops.html | uncaught exception - TypeError: value_list is undefined at test_replaced_values@http://mochi.test:8888/tests/layout/style/test/test_ch_ex_no_infloops.html:40:21 It turns out -moz-column-span are defined _after_ the logic that processes the alias properties. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=077243bccedb472c81457a7710724e52065dc5d5&selectedJob=195621048 [2] https://searchfox.org/mozilla-central/rev/c45b9755593ce6cc91f558b21e544f5165752de7/layout/style/test/property_database.js#7952-7996
Comment on attachment 9003861 [details] Bug 1486074 - Move logic for copying aliased properties' fields to the bottom of property_database.js. Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9003861 - Flags: review+
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d8b05de1fa30 Move logic for copying aliased properties' fields to the bottom of property_database.js. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: