Closed
Bug 1486115
Opened 7 years ago
Closed 7 years ago
use mozilla::IsAsciiDigit and mozilla::AsciiAlphanumericToNumber
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file)
|
5.46 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → longsonr
Attachment #9003901 -
Flags: review?(dholbert)
|
|
Assignee | |
Updated•7 years ago
|
Summary: use mozilla::IsAsciiDigit → use mozilla::IsAsciiDigit and mozilla::AsciiAlphanumericToNumber
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9003901 [details] [diff] [review]
patch
Review of attachment 9003901 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Hooray for code-removal/deduplication. Thanks for doing this.
r=me
Attachment #9003901 -
Flags: review?(dholbert) → review+
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Assignee | |
Comment 4•7 years ago
|
||
As expected, looks like the wpt12 failure is unrelated to this fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d16983528f26ebc12ac53021cb4d90a0358394ec&selectedJob=196767817
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f1ffafbdb88
use mozilla::IsAsciiDigit and mozilla::AsciiAlphanumericToNumber r=dholbert
|
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•