1486144 - bookmarksSidebar.xul -> bookmarksSidebar.xhtml

Status: RESOLVED DUPLICATE of bug 1601094

(Firefox :: Bookmarks & History, enhancement, P2)

Comment 1

[Tim Nguyen :ntim]

Attachment: Make bookmarksSidebar.xul an XHTML document. r=

Comment 2

[Tim Nguyen :ntim]

The tests are filled with those uncaught exceptions when I run them:

  FAIL uncaught exception - ReferenceError: goUpdateGlobalEditMenuItems is not defined at oncommandupdate@chrome://browser/content/places/bookmarksSidebar.xhtml:1:1
onxblselect@chrome://browser/content/places/tree.xml:716:11
PTV_invalidateContainer@chrome://browser/content/places/treeView.js:1079:5
PTV_containerStateChanged@chrome://browser/content/places/treeView.js:921:5
PTV_toggleOpenState@chrome://browser/content/places/treeView.js:1608:26
getNodeForSidebarItem@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:395:5
searchItemInView@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:254:12
assertItemRemoved@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:196:21
async*assertViewsUpdatedCorrectly@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:180:33
async*test/<@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:122:13
async*withSidebarTree@chrome://mochitests/content/browser/browser/components/places/tests/browser/head.js:351:11
async*test@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:98:9
Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1102:34
async*Tester_execTest@chrome://mochikit/content/browser-test.js:1093:16
nextTest/<@chrome://mochikit/content/browser-test.js:995:9
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Stack trace:
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1655
chrome://browser/content/places/tree.xml:onxblselect:716
chrome://browser/content/places/treeView.js:PTV_invalidateContainer:1079
chrome://browser/content/places/treeView.js:PTV_containerStateChanged:921
chrome://browser/content/places/treeView.js:PTV_toggleOpenState:1608
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:getNodeForSidebarItem:395
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:searchItemInView:254
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:assertItemRemoved:196
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:assertViewsUpdatedCorrectly:180
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:test/<:122
chrome://mochitests/content/browser/browser/components/places/tests/browser/head.js:withSidebarTree:351
chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_views_liveupdate.js:test:98
chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
chrome://mochikit/content/browser-test.js:Tester_execTest:1093
chrome://mochikit/content/browser-test.js:nextTest/<:995
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795

Comment 3

[Mark Banner (:standard8)]

Looks like BROWSER_XHTML needs defining somewhere maybe?

https://searchfox.org/mozilla-central/search?q=BROWSER_XHTML&case=false&regexp=false&path=

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Mark Banner (:standard8) from comment #3)
> Looks like BROWSER_XHTML needs defining somewhere maybe?
> 
> https://searchfox.org/mozilla-central/
> search?q=BROWSER_XHTML&case=false&regexp=false&path=

We can't set BROWSER_XHTML directly because it would flip browser.xul->browser.xhtml. But yeah, it's like we need the inc file to be aware of the file it's being included in. 

That, or we need to fix Bug 1483034 so we don't need to add the namespace to those script tags

Comment 5

[Brian Grinstead [:bgrins]]

I'm guessing, although haven't confirmed locally, that various command/menuitems won't be working properly due to a variation on Bug 1479908 (where [command=foo] would end up wiring the observes behavior in XUL docs but not HTML).

Comment 6

[Mark Banner (:standard8)]

I think this was completed in bug 1601094