Closed Bug 1486181 Opened 1 year ago Closed 1 year ago

"Third-Party Cookies" section in the identity popup panel isn't shown appropriately, when not selecting "Third party trackers (recommended)" option in the "Cookies and Site Data" part in the privacy preferences.

Categories

(Firefox :: Site Identity, defect, P1)

63 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: suishouen, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Screenshots.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180824222409

Steps to reproduce:

1. Selecting "All cookies (may causes website to break)" or "All third-party cookies" option in the privacy preferences.
2. Go to http://www.asahi.com/ajw/.
3. Show identity popup panel.


Actual results:

"Third-Party Cookies" section in the identity popup panel shows "Add Blocking…".


Expected results:

"Third-Party Cookies" section in the identity popup panel shows "Blocked".
Blocks: privacy-ui
Has STR: --- → yes
Component: Untriaged → Site Identity and Permission Panels
Ehsan, I agree that's a little confusing, would you like to take this?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(ehsan)
Priority: -- → P2
Third-Party Cookies should show up as blocked in the Control Center if all third party cookies are blocked or if tracking cookies are blocked.  The Third-Party Cookies section should not show up in Control Center if the user has selected the block All cookies option or the block cookies from unvisited sites option.
This can be a followup and stay a P2.
Eiichi, please note that this patch will not make this UI consistent with the options in the Cookies and Site Data UI, but with the UI that is currently under development in bug 1484769.  Over there, we are exposing these two options as the prominent third-party cookie blocking options, and are hiding the rest in the more advanced Cookies and Site Data UI.  We're intentionally making the Control Centre UI consistent with the Content Blocking UI in Preferences.
Flags: needinfo?(ehsan)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 9004445 [details] [diff] [review]
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI

Review of attachment 9004445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/base/content/browser-contentblocking.js
@@ +151,5 @@
>                                            Ci.nsICookieService.BEHAVIOR_ACCEPT);
>      XPCOMUtils.defineLazyPreferenceGetter(this, "visible", this.PREF_UI_ENABLED, false);
>    },
>    get enabled() {
> +    return this.PREF_ENABLED_VALUES.some(value => value == this.behaviorPref);

nit: wouldn't

this.PREF_ENABLED_VALUES.includes(this.behaviorPref);

also work (and be more compact)?

::: browser/base/content/test/trackingUI/browser_trackingUI_state.js
@@ +328,5 @@
> +  for (let value of ThirdPartyCookies.PREF_ENABLED_VALUES) {
> +    Services.prefs.setIntPref(TPC_PREF, value);
> +    ok(ThirdPartyCookies.enabled, "TPC is enabled after setting the pref");
> +    Services.prefs.setBoolPref(CB_PREF, true);
> +    ok(ContentBlocking.enabled, "CB is enabled after setting the pref");

nit: I don't think the content blocking pref needs to be set in that loop

@@ +381,5 @@
> +  for (let value of ThirdPartyCookies.PREF_ENABLED_VALUES) {
> +    Services.prefs.setIntPref(TPC_PREF, value);
> +    ok(ThirdPartyCookies.enabled, "TPC is enabled after setting the pref");
> +    Services.prefs.setBoolPref(CB_PREF, true);
> +    ok(TrackingProtection.enabled, "CB is enabled after setting the pref");

nit: see above, content blocking can be outside of the loop, I feel
Attachment #9004445 - Flags: review?(jhofmann) → review+
I think this bug doesn't do what the original author is asking, so perhaps we need a followup for that in Firefox 64.
(In reply to Tanvi Vyas[:tanvi] from comment #7)
> I think this bug doesn't do what the original author is asking, so perhaps
> we need a followup for that in Firefox 64.

Are you OK with doing what the original author was asking?  I thought you intentionally didn't want to do that...
Flags: needinfo?(tanvi)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a11a4848d40
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI; r=johannh
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2526c62d36d8
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI; r=johannh
https://hg.mozilla.org/mozilla-central/rev/3a11a4848d40
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: needinfo?(ehsan)
I think this doesn't do nothing for this issue, so I opend Bug 1487240.
(In reply to Eiichi from comment #13)
> I think this doesn't do nothing for this issue, so I opend Bug 1487240.

I'm sorry.
To be exact, this bug has been partially fixed.

- Selecting "All third-party cookies" option in the privacy preferences, "Third-Party Cookies" section in the identity popup panel shows "Blocked".

- Selecting "All cookies (will cause website to break)" in the privacy preferences, "Third-Party Cookies" section in the identity popup panel still shows "Add Blocking…".
Status: RESOLVED → VERIFIED
I guess we never filed a follow-up bug here to do the rest of what comment 0 was asking for as per comment 7.  I filed bug 1488906 for that.
Flags: needinfo?(tanvi)
You need to log in before you can comment on or make changes to this bug.