1486181 - "Third-Party Cookies" section in the identity popup panel isn't shown appropriately, when not selecting "Third party trackers (recommended)" option in the "Cookies and Site Data" part in the privacy preferences.

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Eiichi]

Attachment: Screenshots.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180824222409

Steps to reproduce:

1. Selecting "All cookies (may causes website to break)" or "All third-party cookies" option in the privacy preferences.
2. Go to http://www.asahi.com/ajw/.
3. Show identity popup panel.


Actual results:

"Third-Party Cookies" section in the identity popup panel shows "Add Blocking…".


Expected results:

"Third-Party Cookies" section in the identity popup panel shows "Blocked".

Comment 1

[Johann Hofmann [:johannh]]

Ehsan, I agree that's a little confusing, would you like to take this?

Comment 2

[Tanvi Vyas[:tanvi]]

Third-Party Cookies should show up as blocked in the Control Center if all third party cookies are blocked or if tracking cookies are blocked.  The Third-Party Cookies section should not show up in Control Center if the user has selected the block All cookies option or the block cookies from unvisited sites option.

Comment 3

[Tanvi Vyas[:tanvi]]

This can be a followup and stay a P2.

Comment 4

[(no longer active)]

Attachment: Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI

Comment 5

[(no longer active)]

Eiichi, please note that this patch will not make this UI consistent with the options in the Cookies and Site Data UI, but with the UI that is currently under development in bug 1484769.  Over there, we are exposing these two options as the prominent third-party cookie blocking options, and are hiding the rest in the more advanced Cookies and Site Data UI.  We're intentionally making the Control Centre UI consistent with the Content Blocking UI in Preferences.

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9004445 [details] [diff] [review]
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI

Review of attachment 9004445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/base/content/browser-contentblocking.js
@@ +151,5 @@
>                                            Ci.nsICookieService.BEHAVIOR_ACCEPT);
>      XPCOMUtils.defineLazyPreferenceGetter(this, "visible", this.PREF_UI_ENABLED, false);
>    },
>    get enabled() {
> +    return this.PREF_ENABLED_VALUES.some(value => value == this.behaviorPref);

nit: wouldn't

this.PREF_ENABLED_VALUES.includes(this.behaviorPref);

also work (and be more compact)?

::: browser/base/content/test/trackingUI/browser_trackingUI_state.js
@@ +328,5 @@
> +  for (let value of ThirdPartyCookies.PREF_ENABLED_VALUES) {
> +    Services.prefs.setIntPref(TPC_PREF, value);
> +    ok(ThirdPartyCookies.enabled, "TPC is enabled after setting the pref");
> +    Services.prefs.setBoolPref(CB_PREF, true);
> +    ok(ContentBlocking.enabled, "CB is enabled after setting the pref");

nit: I don't think the content blocking pref needs to be set in that loop

@@ +381,5 @@
> +  for (let value of ThirdPartyCookies.PREF_ENABLED_VALUES) {
> +    Services.prefs.setIntPref(TPC_PREF, value);
> +    ok(ThirdPartyCookies.enabled, "TPC is enabled after setting the pref");
> +    Services.prefs.setBoolPref(CB_PREF, true);
> +    ok(TrackingProtection.enabled, "CB is enabled after setting the pref");

nit: see above, content blocking can be outside of the loop, I feel

Comment 7

[Tanvi Vyas[:tanvi]]

I think this bug doesn't do what the original author is asking, so perhaps we need a followup for that in Firefox 64.

Comment 8

[(no longer active)]

(In reply to Tanvi Vyas[:tanvi] from comment #7)
> I think this bug doesn't do what the original author is asking, so perhaps
> we need a followup for that in Firefox 64.

Are you OK with doing what the original author was asking?  I thought you intentionally didn't want to do that...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a11a4848d40
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI; r=johannh

Comment 10

[Tiberius Oros[:tiberius_oros]]

Backed out 2 changesets (bug 1486181) for failures on browser_contentblocking.js

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/05ffd49d554f39ea785431c196c2d302611ec22e

Push with the failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9ddd9b9a99191879a5faffcb161f485c85797116

Failure log file: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9ddd9b9a99191879a5faffcb161f485c85797116&selectedJob=196431651

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2526c62d36d8
Make the Third-Party Cookies section of the Control Centre UI be consistent with the Content Blocking section of the Preferences UI; r=johannh

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3a11a4848d40

Comment 13

[Eiichi]

I think this doesn't do nothing for this issue, so I opend Bug 1487240.

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2526c62d36d8

Comment 15

[Eiichi]

(In reply to Eiichi from comment #13)
> I think this doesn't do nothing for this issue, so I opend Bug 1487240.

I'm sorry.
To be exact, this bug has been partially fixed.

- Selecting "All third-party cookies" option in the privacy preferences, "Third-Party Cookies" section in the identity popup panel shows "Blocked".

- Selecting "All cookies (will cause website to break)" in the privacy preferences, "Third-Party Cookies" section in the identity popup panel still shows "Add Blocking…".

Comment 16

[(no longer active)]

I guess we never filed a follow-up bug here to do the rest of what comment 0 was asking for as per comment 7.  I filed bug 1488906 for that.

Comment 17

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Updating the tracking flag, due to comment 15.