1486205 - Dark UI support for not supported areas on macOS

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P5)

Description

[Arda Çebi]

Attachment: The settings page while Dark mode on macOS is enabled (still light)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180824100112

Steps to reproduce:

{Feature Request}


Actual results:

Some areas of Firefox on macOS are not yet supported by a Dark UI to fit with the system theme. Latest versions of Firefox support automatic theme setting option based on macOS theme setting, but screens such as:
- Settings
- Developer Tools (Inspector)
- WebIDE
- Browser Console
- Library pop-up (History, download etc.)

don't have support for a Dark UI. 


Expected results:

These screens should have a dark mode.

Comment 1

[Andre Klapper]

Please do not prioritize tasks if you do not plan to work on them. Thanks!

Comment 2

[Joshua Nixon]

Attachment: Thunderbird mail UI vs Mac Mail UI in dark mode

Compare Tb b63 (top) with Mac Mail (bottom) - inconsistency in dark mode UI in Tb, especially in buttons and drop-down menus

Comment 3

[Joshua Nixon]

File open dialog (Finder window) renders as light in Firefox 63 and Thunderbird 63 when macOS Mojave dark mode is enabled.
Menu bar on mail compose window (portion of bar with "stoplight" close/minimize/maximize buttons) renders as light, while remainder of window is dark. Mail compose UI has menus and buttons that render light, rather than dark, jarring compared to Mac Mail UI. Where implemented dark theme is great but there are a lot of bits like this that seem not to be complete yet.

Comment 4

[Zhaolin Yu]

Possibly duplicate of bug 1432721.

Comment 5

[Joshua Nixon]

I'd say the other way around. Better to have a single bug covering general adherence to the dark theme than multiple bugs, one for each window or panel that doesn't yet fit.

Comment 6

[Joshua Nixon]

Attachment: Screen Shot 2020-02-26 at 9.15.20 AM.png

Consistency of dark mode much improved in current beta (74.0b1) for main window, but Mail Compose window title bar remains light regardless of whether light or dark theme is selected. All drop-down menus in main Mail window or Mail Compose window use light theme colors.

Comment 7

[Elsie Hupp]

This bug seems to have been somewhat duplicated by Bug 1593390.

tl;dr if you open Info.plist inside the application package and change the value of NSRequiresAquaSystemAppearance to NO (i.e. <false/>), most of the remaining widgets that hadn't supported Dark Mode "just work".

Apparently the reason this hasn't been set by default is that it requires QA testing. I changed the setting on my installation of Firefox, and I'll report back if anything appears egregiously broken.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Elsie Hupp from comment #7)

This bug seems to have been somewhat duplicated by Bug 1593390.

Arda, do you still see the problem? The above bug has been fixed.