1486364 - Clicking on scrolled out expanded object updates the scroll

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

+++ This bug was initially created as a clone of Bug #1469959 +++

STRs:
- open console
- log an object with many properties, eg `document`
- expand the object
- scrolldown until you see `prototype`
- expand prototype

ER: prototype is expanded
AR: viewport scrolls to show the beginning of the object, prototype is not expanded

---

This is a new regression, which I think was caused by https://github.com/devtools-html/debugger.html/pull/6809. 

There was a good reason the test was failing and Bug 1484672 should not have been done (blame's on me 🤦‍♀️).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1486364 - Revert changes in Tree component and test; r=jdescottes.

In https://github.com/devtools-html/debugger.html/pull/6809 a check
was removed in the Tree component because seens as unnecessary, and
a test was modified to accomodate the change. Turns out the test was
needed in its original form, and was surfacing a bug.
This patch rolls back both the change in the Tree component _and_ in
the test.
The Tree modification will be backported to the Github repository.

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 9004136 [details]
Bug 1486364 - Revert changes in Tree component and test; r=jdescottes.

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ccb4b6527c1
Revert changes in Tree component and test; r=jdescottes.

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5ccb4b6527c1