1486413 - The about:config "Search:" bar no longer has an outline when focused

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: search bar aboutconfig has no outline when focused.gif

[Affected versions]:
- Nightly v63.0a1, Build ID 20180826220129

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Steps to reproduce]:
1. Open the browser and navigate to about:config.
2. Click the "I accept the risk" button.
3. Observe the search bar.

[Expected results]:
- The search bar has a blue outline when focused.

[Actual results]:
- The search bar has no outline when focused.

[Regression range]:
Last good revision: fcae76a34c32ad73442d7440a203230c053a7649
First bad revision: f3fa1af05d494c8b363bad855e754d2c472d15af
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fcae76a34c32ad73442d7440a203230c053a7649&tochange=f3fa1af05d494c8b363bad855e754d2c472d15af

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

From the pushlog is seems that bug 1485473 has caused this regression.

Matt, could you please take a look at this?

Comment 2

[Matthew N. [:MattN]]

Oops, simple mistake :(

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1486413 - Revert 'xul|textbox[focused]' rule accidentally added in Bug 1486413. r=sfoster

It was accidentally copied from the previous ruleset for the -moz-ui-invalid rules but I meant to invesigate whether -moz-ui-invalid applied to <xul:textbox> before landing.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9004307 [details]
Bug 1486413 - Revert 'xul|textbox[focused]' rule accidentally added in Bug 1486413. r=sfoster

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6589349f1303
Revert 'xul|textbox[focused]' rule accidentally added in Bug 1486413. r=jaws

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6589349f1303

Comment 8

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly 63.0a1 (Build ID 20180828220157) on Windows 10 x64, Mac 10.13.6 and Arch Linux x64.