1486478 - add aarch64 windows support to msgpack

Status: NEW

(Toolkit :: General, enhancement, P3)

Description

[Nathan Froyd [:froydnj]]

None of the msgpack system/arch-specific header files know much about aarch64, let alone aarch64 windows.

Comment 1

[Nathan Froyd [:froydnj]]

I filed https://github.com/msgpack/msgpack-c/issues/728 for the upstream support, but I suspect we'll probably want something a bit sooner.  rhelmer, are you able to assist here?

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Nathan Froyd [:froydnj] from comment #1)
> I filed https://github.com/msgpack/msgpack-c/issues/728 for the upstream
> support, but I suspect we'll probably want something a bit sooner.  rhelmer,
> are you able to assist here?

Per IRC, we're adding a way to disable libprio (MOZ_LIBPRIO) in bug 1485946.

Since that's the only user of msgpack I've just made this same flag disable both.

Comment 3

[Robert Helmer [:rhelmer]]

We might want to consider moving upstream libprio away from msgpack FWIW... it's only used internally and not for actually sending packets on the wire (they go into the existing Telemetry JSON payload).

I'll file an issue on github.com/mozilla/libprio about that.

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> We might want to consider moving upstream libprio away from msgpack FWIW...
> it's only used internally and not for actually sending packets on the wire
> (they go into the existing Telemetry JSON payload).
> 
> I'll file an issue on github.com/mozilla/libprio about that.

https://github.com/mozilla/libprio/issues/41

Comment 5

[Nathan Froyd [:froydnj]]

I've added the necessary aarch64 definitions to msgpack upstream, so we could either request a release or just import upstream wholesale into libprio.

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Nathan Froyd [:froydnj] from comment #5)
> I've added the necessary aarch64 definitions to msgpack upstream, so we
> could either request a release or just import upstream wholesale into
> libprio.

Excellent, thanks! We have a vendoring script for msgpack by itself that pulls from github: https://searchfox.org/mozilla-central/source/third_party/msgpack/update.sh