1486485 - "Send Alert Text" doesn't replace default user prompt value if text is an empty string

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Because we only type when keys exist the default value will remain, and it is not possible to clear it.

To make this possible the input field needs to be cleared first.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Here the WebDriver spec definition of setting the text:

> Perform user agent dependent steps to set the value of current user prompt’s text field to text.

As such internally Marionette uses `interaction.sendKeysToElement()` similar to the `Element Send Keys` command. Hereby the latter command doesn't replace the content, but concatenates the given `text` at the end.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: [marionette] Replace and not append text for "WebDriver:SendAlertText"

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: [wdspec] Add test for empty text to send_alert_text/send.py

The patch refactors the test file, and also adds an additional test,
which makes sure that the default text of the prompt is replaced in
case of an empty string is send as text.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b98d46fabd5a0bb6afe3ffccf736752f9a0879b5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3ea8e988254
[marionette] Replace and not append text for "WebDriver:SendAlertText". r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/82dc592c7293
[wdspec] Add test for empty text to send_alert_text/send.py. r=jgraham

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12735 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f3ea8e988254
https://hg.mozilla.org/mozilla-central/rev/82dc592c7293

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged