1486525 - Add GeckoView test for onLoadRequest redirect handling

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[Dylan Roeh (:droeh) (he/him)]

We need to add a test for the redirect onLoadRequest handling introduced in bug 1478171.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Test redirect onLoadRequest handling

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9004558 [details] [diff] [review]
Test redirect onLoadRequest handling

Review of attachment 9004558 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/NavigationDelegateTest.kt
@@ +203,5 @@
>  
> +    @Test fun redirectLoad() {
> +        assumeThat(sessionRule.env.isAutomation, equalTo(true))
> +
> +        val uri = "http://example.org/tests/robocop/simple_redirect.sjs?http://example.org/tests/robocop/robocop_blank_02.html"

Use `val uri = "http://example.org/tests/robocop/simple_redirect.sjs?$redirectUri"

@@ +204,5 @@
> +    @Test fun redirectLoad() {
> +        assumeThat(sessionRule.env.isAutomation, equalTo(true))
> +
> +        val uri = "http://example.org/tests/robocop/simple_redirect.sjs?http://example.org/tests/robocop/robocop_blank_02.html"
> +        val redirectUri = "http://example.org/tests/robocop/robocop_blank_02.html"

Does it still work if you change the target URL to what `createTestUrl(HELLO_HTML_PATH)` returns? I'd rather have us use our GV test pages as much as possible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f22d0641fd3d
Add NavigationDelegateTest.redirectLoad() to test redirect onLoadRequest handling. r=jchen

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f22d0641fd3d

Comment 5

[Dylan Roeh (:droeh) (he/him)]

I @Ignored this test as part of the backout of bug 1441059 and bug 1478171; reopening so we remember to reenable the test when redirect onLoadRequest handling is working again.

Comment 6

[Dylan Roeh (:droeh) (he/him)]

(In reply to Dylan Roeh (:droeh) from comment #5)
> I @Ignored this test as part of the backout of bug 1441059 and bug 1478171;
> reopening so we remember to reenable the test when redirect onLoadRequest
> handling is working again.

The test was reenabled as part of bug 1478171; closing this.