1486554 - Enable static analysis on all Windows CI builds, turn off separate static analysis build tasks

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, enhancement)

Description

[(not currently active) Ted Mielczarek]

Once someone figures out bug 1427808, which is keeping the Windows static analysis builds on an older version of clang, we should be able to just enable static analysis in all of our Windows CI builds, and turn off the separate static analysis build tasks, which will save on build resources. We did this for mac in bug 1208787.

Comment 1

[Mike Hommey [:glandium]]

We can do the same with Linux, now that Linux builds are on clang too. In fact, I have a patch for that already.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1486554 - Enable static analysis on normal Windows CI builds

And turn off separate static analysis build tasks.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1486554 - Use the normal debug mozharness config for Windows static analysis autotest

Now that all Windows builds have static analysis enabled, the
clang_debug mozharness config does not have any relevant difference for
those jobs, so just use the debug mozharness config instead.

Depends on D8810

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1486554 - Remove the now unused clang and clang_debug mozharness configs and corresponding files

Depends on D8811

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60d974e18e6a
Enable static analysis on normal Windows CI builds r=ted
https://hg.mozilla.org/integration/autoland/rev/7f518733a402
Use the normal debug mozharness config for Windows static analysis autotest r=ted
https://hg.mozilla.org/integration/autoland/rev/364f270ff9bf
Remove the now unused clang and clang_debug mozharness configs and corresponding files r=ted

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/60d974e18e6a
https://hg.mozilla.org/mozilla-central/rev/7f518733a402
https://hg.mozilla.org/mozilla-central/rev/364f270ff9bf

Comment 7

[(Away)]

We should remove the win*-st-an platforms from https://mozilla-releng.net/trychooser/ (I can't currently find in my history where that code lives, I think it might be github somewhere)