1486652 - Make x86 linux builds actual cross builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Make x86 linux builds actual cross builds

The x86 linux builds originally were performed in x86 build environment.
That was a long time ago. Since then, they moved to x86-64 hosts with
x86 headers and libraries. But for reasons that might have to do with
the build system not really supporting cross-compilation nicely back
then, the build is still explicitly passing both --host and --target,
making those builds non-cross builds.

Since the toolchains used to build are for x86-64, the fact that --host
is for x86 actually prevents enabling the clang plugin, so we need to
turn these builds in actual cross builds if we want to enable the clang
plugin.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 9004412 [details] [diff] [review]
Make x86 linux builds actual cross builds

Review of attachment 9004412 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! This has tripped me up a few times over the years.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9da60503ea49
Make x86 linux builds actual cross builds. r=ted

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 9da60503ea49 (bug 1486652) for wd failures on /builds/worker/workspace/build/tests/bin/geckodriver 

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=196348295&repo=mozilla-inbound&lineNumber=891

INFO - Reading from file tmpfile_stdout
[task 2018-08-29T01:45:04.126Z] 01:45:04     INFO - Output received:
[task 2018-08-29T01:45:04.126Z] 01:45:04     INFO -  Usage: mozinstall [options] installer
[task 2018-08-29T01:45:04.126Z] 01:45:04     INFO -  Options:
[task 2018-08-29T01:45:04.127Z] 01:45:04     INFO -    -h, --help            show this help message and exit
[task 2018-08-29T01:45:04.127Z] 01:45:04     INFO -    -d DEST, --destination=DEST
[task 2018-08-29T01:45:04.127Z] 01:45:04     INFO -                          Directory to install application into. [default:
[task 2018-08-29T01:45:04.127Z] 01:45:04     INFO -                          "/builds/worker/workspace"]
[task 2018-08-29T01:45:04.128Z] 01:45:04     INFO -    --app=APP             Application being installed. [default: firefox]
[task 2018-08-29T01:45:04.128Z] 01:45:04     INFO - mkdir: /builds/worker/workspace/build/application
[task 2018-08-29T01:45:04.129Z] 01:45:04     INFO - Getting output from command: ['/builds/worker/workspace/build/venv/bin/mozinstall', '/builds/worker/workspace/build/target.tar.bz2', '--destination', '/builds/worker/workspace/build/application']
[task 2018-08-29T01:45:04.129Z] 01:45:04     INFO - Copy/paste: /builds/worker/workspace/build/venv/bin/mozinstall /builds/worker/workspace/build/target.tar.bz2 --destination /builds/worker/workspace/build/application
[task 2018-08-29T01:45:20.139Z] 01:45:20     INFO - Reading from file tmpfile_stdout
[task 2018-08-29T01:45:20.140Z] 01:45:20     INFO - Output received:
[task 2018-08-29T01:45:20.140Z] 01:45:20     INFO -  /builds/worker/workspace/build/application/firefox/firefox
[task 2018-08-29T01:45:20.141Z] 01:45:20     INFO - Running post-action listener: _resource_record_post_action
[task 2018-08-29T01:45:20.141Z] 01:45:20     INFO - [mozharness: 2018-08-29 01:45:20.141665Z] Finished install step (success)
[task 2018-08-29T01:45:20.142Z] 01:45:20     INFO - [mozharness: 2018-08-29 01:45:20.141945Z] Running run-tests step.
[task 2018-08-29T01:45:20.142Z] 01:45:20     INFO - Running pre-action listener: _resource_record_pre_action
[task 2018-08-29T01:45:20.142Z] 01:45:20     INFO - Running pre-action listener: _set_gcov_prefix
[task 2018-08-29T01:45:20.142Z] 01:45:20     INFO - Running main action method: run_tests
[task 2018-08-29T01:45:20.157Z] 01:45:20     INFO - ENV: RUST_BACKTRACE is now full
[task 2018-08-29T01:45:20.158Z] 01:45:20     INFO - ENV: MOZ_LAYERS_ALLOW_SOFTWARE_GL is now 1
[task 2018-08-29T01:45:20.158Z] 01:45:20     INFO - ENV: STYLO_THREADS is now 4
[task 2018-08-29T01:45:20.158Z] 01:45:20     INFO - ENV: MINIDUMP_SAVE_PATH is now /builds/worker/workspace/build/blobber_upload_dir
[task 2018-08-29T01:45:20.158Z] 01:45:20     INFO - mkdir: /builds/worker/workspace/build/blobber_upload_dir
[task 2018-08-29T01:45:20.160Z] 01:45:20    FATAL - Unable to find geckodriver binary in common test package: /builds/worker/workspace/build/tests/bin/geckodriver
[task 2018-08-29T01:45:20.160Z] 01:45:20    FATAL - Running post_fatal callback...
[task 2018-08-29T01:45:20.161Z] 01:45:20    FATAL - Exiting -1
[task 2018-08-29T01:45:20.161Z] 01:45:20     INFO - Running post-action listener: _package_coverage_data
[task 2018-08-29T01:45:20.161Z] 01:45:20     INFO - Running post-action listener: _resource_record_post_action
[task 2018-08-29T01:45:20.162Z] 01:45:20     INFO - Running post-action listener: process_java_coverage_data
[task 2018-08-29T01:45:20.162Z] 01:45:20     INFO - [mozharness: 2018-08-29 01:45:20.162157Z] Finished run-tests step (failed)
[task 2018-08-29T01:45:20.162Z] 01:45:20     INFO - Running post-run listener: _resource_record_post_run
[task 2018-08-29T01:45:20.222Z] 01:45:20     INFO - Total resource usage - Wall time: 16s; CPU: 25.0%; Read bytes: 0; Write bytes: 156082176; Read time: 0; Write time: 19924
[task 2018-08-29T01:45:20.222Z] 01:45:20     INFO - TinderboxPrint: CPU usage<br/>25.3%
[task 2018-08-29T01:45:20.223Z] 01:45:20     INFO - TinderboxPrint: I/O read bytes / time<br/>0 / 0
[task 2018-08-29T01:45:20.223Z] 01:45:20     INFO - TinderboxPrint: I/O write bytes / time<br/>156,082,176 / 19,924
[task 2018-08-29T01:45:20.223Z] 01:45:20     INFO - TinderboxPrint: CPU idle<br/>47.6 (74.3%)
[task 2018-08-29T01:45:20.224Z] 01:45:20     INFO - TinderboxPrint: CPU user<br/>15.7 (24.5%)
[task 2018-08-29T01:45:20.224Z] 01:45:20     INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2018-08-29T01:45:20.224Z] 01:45:20     INFO - pull - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2018-08-29T01:45:20.225Z] 01:45:20     INFO - install - Wall time: 16s; CPU: 25.0%; Read bytes: 0; Write bytes: 156082176; Read time: 0; Write time: 19924
[task 2018-08-29T01:45:20.225Z] 01:45:20     INFO - run-tests - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2018-08-29T01:45:20.232Z] 01:45:20     INFO - Running post-run listener: copy_logs_to_upload_dir
[task 2018-08-29T01:45:20.232Z] 01:45:20     INFO - Copying logs to upload dir...
[task 2018-08-29T01:45:20.232Z] 01:45:20     INFO - mkdir: /builds/worker/workspace/build/upload/logs
[task 2018-08-29T01:45:20.254Z] cleanup
[task 2018-08-29T01:45:20.254Z] + cleanup

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2b045052d4aad4e77f3b8fce35a40efeed4e19f1&selectedJob=196348295

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5542bf92e540a15b2cae27f7d841748d4f1cc0ce

Comment 5

[Mike Hommey [:glandium]]

So the problem is that geckodriver defaults to being disabled on cross-compilations. But we can, actually, enable it manually on 32-bits linux builds. I'll reland with that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/424d07248f36
Make x86 linux builds actual cross builds. r=ted

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/424d07248f36