Closed Bug 1486674 Opened 3 years ago Closed 3 years ago

get rid of nsIDOMXULCheckboxElement

Categories

(Core :: XUL, task)

Product:
Core
Component:
XUL
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

patch
1.96 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
after bug 1486671 is fixed, it seems there's no other dependencies on this interface. Also see bug 1455433 - XUL:checkbox dexblization - for details.
Attachment #9004440 - Flags: review?(bugs)
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Depends on: 1486671
Attachment #9004440 - Attachment mime type: text/x-patch → text/plain
Attachment #9004440 - Attachment is patch: true
Comment on attachment 9004440 [details] [diff] [review]
patch


>  * The checkbox storing whether the user wants to remember the selected cert.
>- * @type nsIDOMXULCheckboxElement
>+ * @type a dom::Element checkbox, has to have |checked| property.
Element, not dom::Element.  (::dom:: is after all a namespace in C++, not in JS)
Attachment #9004440 - Flags: review?(bugs) → review+
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6567e31d48
get rid of nsIDOMXULCheckboxElement, r=smaug
https://hg.mozilla.org/mozilla-central/rev/bc6567e31d48
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Type: defect → task
You need to log in before you can comment on or make changes to this bug.