get rid of nsIDOMXULCheckboxElement

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Posted patch patchSplinter Review
after bug 1486671 is fixed, it seems there's no other dependencies on this interface. Also see bug 1455433 - XUL:checkbox dexblization - for details.
Attachment #9004440 - Flags: review?(bugs)
Blocks: 1397874
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED

Updated

7 months ago
Depends on: 1486671

Updated

7 months ago
Attachment #9004440 - Attachment mime type: text/x-patch → text/plain

Updated

7 months ago
Attachment #9004440 - Attachment is patch: true
Comment on attachment 9004440 [details] [diff] [review]
patch


>  * The checkbox storing whether the user wants to remember the selected cert.
>- * @type nsIDOMXULCheckboxElement
>+ * @type a dom::Element checkbox, has to have |checked| property.
Element, not dom::Element.  (::dom:: is after all a namespace in C++, not in JS)
Attachment #9004440 - Flags: review?(bugs) → review+

Comment 2

7 months ago
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6567e31d48
get rid of nsIDOMXULCheckboxElement, r=smaug

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc6567e31d48
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.