1486739 - Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Mark Banner (:standard8)]

As discussed on firefox-dev and dev.platform, we should require dangling commas for multi-line object/arrays in Javascript code for mozilla-central.

Why:

- Multiple components in toolkit/ and browser/ already have comma-dangle enabled.
- Having asked around in a few locations, I'm seeing support from the Firefox developer team and others in favour of enabling it.
- It helps make blame cleaner.
- It makes editing easier, and helps for a consistent style.
- Having automation available to cover the requirement reduces the need for review nits.

This bug is for the first half of the files, namely those in:

browser/
services/
taskcluster/
toolkit/

In the patches I'm effectively enabling the rule for ESLint by default, and then blacklisting the other directories.

I am hoping to land this bug on Friday 31 August (GMT timezone), ahead of the 63 merges.

Comment 1

[Mark Banner (:standard8)]

Current stats: 1576 files changed, 7754 insertions(+), 7753 deletions(-)

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/.

Automatic changes by ESLint, except for manual corrections for .xml files.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1486739 - Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/ directories.

Enable globally by default by blacklist directories outside of the ones we're enabling. Remove now unnecessary existing configurations.

Comment 5

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f25623be75a70f030d7d0bc67a5f74d6a0649243

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 9004528 [details]
Bug 1486739 - Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/ directories.

Dave Townsend [:mossop] has approved the revision.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 9004527 [details]
Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/.

Dave Townsend [:mossop] has approved the revision.

Comment 8

[Mark Banner (:standard8)]

Up to date try push with a couple of extra comma fixes. I'll be landing this tomorrow morning UK time.

Comment 9

[Mark Banner (:standard8)]

And now with the link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef18eb046edff9f4a7a0f390f27b0f2438a6cace

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7fcfbc15cfe
Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc6d1a2d201
Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/ directories. r=mossop

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d7fcfbc15cfe
https://hg.mozilla.org/mozilla-central/rev/1bc6d1a2d201

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2076b6d27823afbdeef4abcfc0efe79a40acd13b
Port Bug 1486739 - Enable ESLint rule comma-dangle for browser/, services/, taskcluster/ and toolkit/ directories. r=mossop

Comment 14

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4435