1486765 - Add installTelemetryInfo to addon installed from Marionette

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is a follow-up issue for Bug 1433334.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1486765 - Add installTelemetryInfo to addon installed from Marionette. r=ato

Comment 2

[Andreas Tolfsen ❲:ato❳]

Please note that maja_zf is on maternity leave.  Please r? me for
any testing/marionette changes.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 9008111 [details]
Bug 1486765 - Add installTelemetryInfo to addon installed from Marionette. r=ato

Andreas Tolfsen ❲:ato❳ has approved the revision.

Comment 4

[Andrew Swan [:aswan]]

Why are we adding this?  Telemetry should be disabled in any marionette managed profile

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Andrew Swan [:aswan] from comment #4)
> Why are we adding this?  Telemetry should be disabled in any marionette
> managed profile

The main reason is that marionette is used internally by selenium webdriver, and so I thought it is better to mark them with a telemetryInfo source, in case the telemetry has been enabled (by mistake or on purpose) in a Firefox profile controlled by selenium webdriver.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

As agreed with :aswan over IRC, I'm going to change this patch to mark the addon installed from the Marionette to a generic "internal" source, and then that source is going to be used in Bug 1433335 to avoid recording telemetry events.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0402123a0238
Add installTelemetryInfo to addon installed from Marionette. r=ato

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0402123a0238