Closed Bug 1486768 Opened Last year Closed Last year

Fix mocha tests

Categories

(DevTools :: Console, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

Looks like we have a few failures on mocha that we should fix if we want those tests to be run on CI later.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P3
Some tests were failing because of change in the code:
- arrow icon don't have an expanded class anymore but use aria-expanded
- executionPoint property wasn't set on the ConsoleMessageType
- networkUpdateRequest action expects a second argument
- requestHeadersFromUploadStream is retrieved from requestPostData.uploadHeaders
Comment on attachment 9004549 [details]
Bug 1486768 - Fix mocha tests;r=Honza.

Jan Honza Odvarko [:Honza] has approved the revision.
Attachment #9004549 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9550be79a88e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.