Closed Bug 1486783 Opened 2 years ago Closed 2 years ago

Fix some undefined property references in PlacesUtils.jsm and History.jsm

Categories

(Toolkit :: Places, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

I believe I've noticed this running a few of the history tests, but I also noticed this recently when working on test_DownloadLegacy.js.

There's a couple of strict warnings raised near the start of the test:

JavaScript strict warning: resource://gre/modules/PlacesUtils.jsm, line 1065: ReferenceError: reference to undefined property "description"
JavaScript strict warning: resource://gre/modules/History.jsm, line 1518: ReferenceError: reference to undefined property "description"

When I fix those, it also reveals warnings about "previewImageURL".

Not a huge priority, but I think we should fix those anyway to make the output cleaner.
Comment on attachment 9004566 [details]
Bug 1486783 - Fix some undefined property references to description and previewImageURL in PlacesUtils.jsm and History.jsm.

Marco Bonardo [::mak] has approved the revision.
Attachment #9004566 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24ecf2822560
Fix some undefined property references to description and previewImageURL in PlacesUtils.jsm and History.jsm. r=mak
https://hg.mozilla.org/mozilla-central/rev/24ecf2822560
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.