Closed
Bug 1486808
Opened 6 years ago
Closed 6 years ago
Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId
Categories
(Toolkit :: Places, enhancement, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
I think we are now in a position where I think we can remove unfiledBookmarksFolder / unfiledBookmarksFolderId. The only places in production code where it is still used is in the places DB maintenance, and I think we can replace those with simple SELECTs. Some of the test instances are checking notifications. I think we can replace these with `promiseItemId(PlacesUtils.bookmarks.unfiledGuid);` for now - as we rewrite the notifications, we'll hopefully be dropping the item ids, and hence they'll gradually go away.
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9004582 [details] Bug 1486808 - Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId. Marco Bonardo [::mak] has approved the revision.
Attachment #9004582 -
Flags: review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9de4c7559795 Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId. r=mak
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9de4c7559795
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•