Bug 1486808 - Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId.
46 bytes, text/x-phabricator-request
|Details | Review|
I think we are now in a position where I think we can remove unfiledBookmarksFolder / unfiledBookmarksFolderId. The only places in production code where it is still used is in the places DB maintenance, and I think we can replace those with simple SELECTs. Some of the test instances are checking notifications. I think we can replace these with `promiseItemId(PlacesUtils.bookmarks.unfiledGuid);` for now - as we rewrite the notifications, we'll hopefully be dropping the item ids, and hence they'll gradually go away.
Comment on attachment 9004582 [details] Bug 1486808 - Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId. Marco Bonardo [::mak] has approved the revision.
Attachment #9004582 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9de4c7559795 Remove nsINavBookmarksService::unfiledBookmarksFolder and PlacesUtils.unfiledBookmarksFolderId. r=mak
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.