1486891 - Font editor: add dedicated input for font preview text

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Razvan Caliman [:rcaliman]]

- adds a dedicated input for text used to generate font previews;
- removes old input fields from font previews;
- misc refactoring

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1486891 - (Part 1) Add dedicated input for font preview in font editor. r=gl

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1486891 - (Part 2) Remove old font preview functionality from font editor. r=gl

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9004654 [details]
Bug 1486891 - (Part 1) Add dedicated input for font preview in font editor. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9004656 [details]
Bug 1486891 - (Part 2) Remove old font preview functionality from font editor. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Reminder that we also need to update the unit tests.

Comment 6

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=266721f14887e29f679776d04d9ca5b8da46d51d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f2c35dde932
(Part 1) Add dedicated input for font preview in font editor. r=gl

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad015aaf131
(Part 2) Remove old font preview functionality from font editor. r=gl

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4804e9ef844f
Backed out 2 changesets for turning bug 1176376 into permafail. CLOSED TREE

Comment 10

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1f2c35dde932439e01e2e70a14df5a6d8be724d8&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=Windows%2010%20x64%20pgo%20Mochitests%20with%20e10s%20test-windows10-64-pgo%2Fopt-mochitest-devtools-chrome-e10s-8%20M-e10s(dt8)&selectedJob=196473730

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196473730&repo=autoland&lineNumber=2727

16:52:00     INFO - TEST-PASS | devtools/client/inspector/fonts/test/browser_fontinspector_edit-previews.js | The input was focused. - 
16:52:00     INFO - Blanking the input field.
16:52:00     INFO - Typing the specified text to the input field.
16:52:00     INFO - Waiting for event: 'fontinspector-updated' on [object Object].
16:52:00     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 946}]
16:52:00     INFO - Console message: [JavaScript Error: "TypeError: this.props.onPreviewFonts is not a function" {file: "resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/fonts/components/FontPreview.js" line: 54}]
16:52:00     INFO - Console message: [JavaScript Error: "TypeError: this.props.onPreviewFonts is not a function" {file: "resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/fonts/components/FontPreview.js" line: 54}]
16:52:00     INFO - Console message: [JavaScript Error: "TypeError: this.props.onPreviewFonts is not a function" {file: "resource://devtools/shared/base-loader.js -> resource://devtools/client/inspector/fonts/components/FontPreview.js" line: 54}]
16:52:00     INFO - Buffered messages finished
16:52:00     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/fonts/test/browser_fontinspector_edit-previews.js | Test timed out - 
16:52:00     INFO - Removing tab.
16:52:00     INFO - Waiting for event: 'TabClose' on [object XULElement].
16:52:00     INFO - Got event: 'TabClose' on [object XULElement].
16:52:00     INFO - Tab removed and finished closing
16:52:00     INFO - GECKO(9024) | MEMORY STAT | vsize 1810MB | vsizeMaxContiguous 132129717MB | residentFast 297MB | heapAllocated 114MB
16:52:00     INFO - TEST-OK | devtools/client/inspector/fonts/test/browser_fontinspector_edit-previews.js | took 45295ms

Comment 11

[Razvan Caliman [:rcaliman]]

There are two patches for this bug. The first patch removes the old behavior but keeps the test unchanged. The second patch adds new behavior and updates the test. When applied sequentially, the first one fails the test. I will fix this and attempt another landing.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a13d10011ddc
(Part 1) Add dedicated input for font preview in font editor. r=gl
https://hg.mozilla.org/integration/mozilla-inbound/rev/86f0ae834ff9
(Part 2) Remove old font preview functionality from font editor. r=gl

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a13d10011ddc
https://hg.mozilla.org/mozilla-central/rev/86f0ae834ff9