Closed Bug 1486915 Opened Last year Closed Last year
Use the "hidden" attribute instead of a "hide" class in about
Private Browsing .js
46 bytes, text/x-phabricator-request
|Details | Review|
Currently in about:privatebrowsing, we set a class called "hide"  to hide elements we don't want to show.  https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#23  https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.css#8 We should probably switch that use the "hidden" attribute.
Assignee: nobody → cadeyrn
Status: NEW → ASSIGNED
Comment on attachment 9005848 [details] Bug 1486915 - Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js Johann Hofmann [:johannh] has approved the revision.
Attachment #9005848 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/30ca1de16fa5 Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js r=johannh
You need to log in before you can comment on or make changes to this bug.