Closed Bug 1486915 Opened 2 years ago Closed 2 years ago

Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js

Categories

(Firefox :: Private Browsing, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: johannh, Assigned: soeren.hentzschel, Mentored)

Details

Attachments

(1 file)

Currently in about:privatebrowsing[0], we set a class called "hide" [1] to hide elements we don't want to show. 

[0] https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#23
[1] https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.css#8

We should probably switch that use the "hidden" attribute.
Assignee: nobody → cadeyrn
Status: NEW → ASSIGNED
Comment on attachment 9005848 [details]
Bug 1486915 - Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js

Johann Hofmann [:johannh] has approved the revision.
Attachment #9005848 - Flags: review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30ca1de16fa5
Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js r=johannh
https://hg.mozilla.org/mozilla-central/rev/30ca1de16fa5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.