Closed
Bug 1486915
Opened 6 years ago
Closed 6 years ago
Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js
Categories
(Firefox :: Private Browsing, enhancement, P5)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: johannh, Assigned: soeren.hentzschel, Mentored)
Details
Attachments
(1 file)
Currently in about:privatebrowsing[0], we set a class called "hide" [1] to hide elements we don't want to show. [0] https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#23 [1] https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.css#8 We should probably switch that use the "hidden" attribute.
|
Assignee | |
Comment 1•6 years ago
|
||
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → cadeyrn
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9005848 [details] Bug 1486915 - Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js Johann Hofmann [:johannh] has approved the revision.
Attachment #9005848 -
Flags: review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30ca1de16fa5 Use the "hidden" attribute instead of a "hide" class in aboutPrivateBrowsing.js r=johannh
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/30ca1de16fa5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•