1486968 - Remove nsPrintJob::mOldPrtPreview

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P3)

Description

[Jonathan Watt [:jwatt]]

The purpose of nsPrintJob::mOldPrtPreview is unclear and the code inconsistent in its use. We should try to remove this member. I tried that in bug 1425641 previously, but it caused browser chrome test toolkit/components/printing/tests/browser_page_change_print_original.js to fail.

Comment 1

[Jonathan Watt [:jwatt]]

It turns out that the crash wasn't a result of failing to keep mOldPrtPreview around to hold onto for something. Rather, the issue was that we need to clear mPrtPreview (a side affect of mOldPrtPreview = std::move(mPrtPreview)) so that we didn't use that stale object.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1486968. Remove nsPrintJob::mOldPrtPreview. r=bobowen

Comment 3

[Jonathan Watt [:jwatt]]

Try push, for the record:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cc53badd9670795a27214eed40658db6ba9867d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60e9aedf5428
Remove nsPrintJob::mOldPrtPreview. r=bobowen

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/60e9aedf5428

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out from Beta for Fx73. This remains fixed on m-c for 74+.
https://hg.mozilla.org/releases/mozilla-beta/rev/00808d720d1b9a942a8e5f68aa9f6019367b18a0