1487047 - We seem to not honour system keyboard focus ring settings correctly for popup windows

Status: NEW

(Core :: Widget: Win32, defect, P3)

Description

[David Olah]

[Affected versions]
63.0a1 (2018-08-22)

[Affected platforms]
Windows 10, Windows 7

[Steps to reproduce]
1. Open Firefox and in the Hamburger Menu, click on Content Blocking
2. about:preferences#privacy will be opened and Content Blocking section will be focused
3. Set Slow tracking element to "Always block"
4. Set Trackers to "Never block"
5. Access: https://www.reddit.com/ (or any other site with slow trackers)
6. Open "Show site information" from the address bar
7. Navigate using the Tab key

[Expected result]
Each element is highlighted when it's being selected by the tab key

[Actual result]
"Add blocking" and "Report a problem" links are not highlighted

Comment 1

[(no longer active)]

I can't reproduce on Linux.

Comment 2

[Johann Hofmann [:johannh]]

I can't reproduce on Windows 7 either.

Comment 3

[(no longer active)]

David, can you please clarify the steps to reproduce?  Thanks!

Comment 4

[David Olah]

Attachment: 2018-09-05_1907.swf

I attached here a video, in which, as you can see, using the tab key multiple times to navigate through the panel, the gear button is being highlighted, the "add blocking" links are not highlighted, "disable blocking for this site" is also highlighted and report a problem is also not highlighted. 

I managed to reproduce the issue also on: Nightly 64.0a1 (2018-09-04)

Comment 5

[(no longer active)]

Sigh... I have no software on my computer to play SWF files.  ;-)

Johann, if you wanted to pick a bug this would be a good candidate, I'm not planning to work on it.

Comment 6

[Johann Hofmann [:johannh]]

Yeah, me neither, I guess I'll have to download some malware...

Comment 7

[Johann Hofmann [:johannh]]

David, I can't get this file to play, can you please upload it in a more common format, such as .mp4?

Thanks!

Comment 8

[David Olah]

Sure. Here you can find a link of the video: https://www.screencast.com/t/YFkEA6txN91U

Comment 9

[Johann Hofmann [:johannh]]

Hm, I can't reproduce this on Windows 10 either :(

Considering that there's a video of this but none of us who are working on it can reproduce, I'll just set this to P3 and put it in the project backlog. Not sure what else we can do.

Comment 10

[David Olah]

I don't understand why it is not reproducing on your side. I tried on windows 10 on 3 PCs and I can reproduce the issue on all of them. On mouse hover, for example, the "Add blocking..." links are underlined (that is the expected behaviour). When navigating through them with the tab key, the links are not underlined.

Comment 11

[Johann Hofmann [:johannh]]

Attachment: Screen Shot 2018-09-10 at 15.13.59.png

This is how it look for me :|

Comment 12

[(no longer active)]

I think this bug is actually a missing fix from bug 418521.

I think what is happening here is that we fail to handle eWindowType_popup here <https://searchfox.org/mozilla-central/rev/881a3c5664ede5e08ee986d76433bc5c4b5680e6/widget/windows/nsWindow.cpp#6176>, as a result we don't correctly switch to showing the focus ring when the user starts to use the keyboard inside a popup window based on the system settings.  This normally works for top-level windows or dialogs, as can be seen in the code there.