1487120 - Progress indicator on About menu doesn't animate

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Chris H-C :chutten]

This was especially noticeable when I was experiencing a network bug that stalled DNS requests... but even now, if I Help>About Nightly on Windows or Linux, the progress spinner doesn't animate unless the content of the update progress string updates.

It seems as though it decides not to paint for some reason? May not be Update's fault then, maybe be some sort of webrendest thing.

Beta seems unaffected for now.

Comment 1

[Molly Howell (she/her) (no longer active)]

Hmm. Yeah, we don't really exercise any control over that animation, it's just an animated PNG sitting in a XUL <image> element. The text string next to it is updated on its own. So this does sound like a lower-level bug. Since you mentioned you've got webrender on, I'll move this over there, but I'm not certain if that's where the problem is or not.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Can you reproduce this with WebRender off?

Comment 3

[Darkspirit]

mozregression --good 2018-01-15 --bad 2018-04-01 --pref gfx.webrender.all:true dom.allow_XUL_XBL_for_file:true -a file:///home/darkspirit/Schreibtisch/wr/testcase.xul
> 8:58.51 INFO: Last good revision: 8d73f18bc1a2097f1271d9d3af554cd23bcc9324
> 8:58.51 INFO: First bad revision: c0200f9fc1abf1e34a0bb1acb5a9f57d38ca677b
> 8:58.51 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d73f18bc1a2097f1271d9d3af554cd23bcc9324&tochange=c0200f9fc1abf1e34a0bb1acb5a9f57d38ca677b

> c0200f9fc1ab	Jeff Muizelaar — Bug 1439006. Allow multiple kinds of WebRenderUserData on a DisplayItem. r=mstange

Comment 4

[Darkspirit]

Attachment: testcase.xul

Comment 5

[Darkspirit]

I saw this bug for a long time, but didn't thought about it. I can't reproduce without WebRender.

Comment 6

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #4)
> Created attachment 9004952 [details]
> testcase.xul

This is basically https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/base/content/aboutDialog.xul, but I removed all ifdefs, some hboxes and changed <hbox id="checkingForUpdates" to be a div.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Hm, the progress indicator is just an APNG. We appear to get the nsImageBoxFrame::OnFrameUpdate as expected but it doesn't trigger an nsImageBoxFrame::CreateWebRenderCommands to resample the animation, so it appears still.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Appears XUL images don't invalidate properly for WebRender. Patch forth coming.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1487120-Invalidate-nsImageBoxFrame-properly-for-.patch, v1

All we were missing was the same check from nsImageFrame::InvalidateSelf.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8cef23e037b140b2f643ff757975a36938b135

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9005190 [details] [diff] [review]
0001-Bug-1487120-Invalidate-nsImageBoxFrame-properly-for-.patch, v1

Review of attachment 9005190 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/nsImageBoxFrame.cpp
@@ +902,5 @@
>      return NS_OK;
>    }
>  
> +  // XXX: Do we really want to check whether we have a
> +  // WebRenderUserDataProperty?

Check if WebRender has interacted with this frame. If it has
we need to let it know that things have changed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21fc9db28902
Invalidate nsImageBoxFrame properly for WebRender. r=jrmuizel

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/21fc9db28902