1487121 - proxyType is marked as optional but proxy.settings.set raises an error when it is missing

Status: VERIFIED FIXED

(WebExtensions :: Request Handling, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

proxyType is marked as optional in the API schema [1] and it is also documented on MDN as optional with "system" as its default value, but proxy.settings.set is currently raising an "undefined is not a valid value for proxyType." error when it is missing (https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/toolkit/components/extensions/parent/ext-proxy.js#233).


[1]: https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/toolkit/components/extensions/schemas/proxy.json#28
[2]: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1487121 - Allow proxy.settings.set calls without an explicit proxyType property.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9004922 [details]
Bug 1487121 - Allow proxy.settings.set calls without an explicit proxyType property.

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4ca43d3fc1b
Allow proxy.settings.set calls without an explicit proxyType property. r=mixedpuppy

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f4ca43d3fc1b

Comment 5

[Vlad Jiman]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 6

[CosminB]

Attachment: Bug1487121.gif

I was able to reproduce this issue on Firefox 62.0(20180830143136) under Win 7 64-bit and  Mac OS X 10.13.3.

This issue is verified as fixed on Firefox 64.0a1(20180906232139) and Firefox 63.0b4(20180906162647) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.