1487126 - updatecommon.cpp compilation fails on MinGW because 3-argument wcstok cannot be found

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell

the Mingw Clang build failed because a 3-argument form of wcstok could not
be found, despite it apparently being part of the C++ standard. Multiple
forms of header files were tried.

By comparison, wcstok_s is already used (e.g. widget/windows/WinUtils.cpp)
and does the correct thing. So change the functions over to that one.

Comment 2

[Molly Howell (she/her) (no longer active)]

Comment on attachment 9004931 [details]
Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell

Matt Howell [:mhowell] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59227967b5b5
Change uses of 3-argument wcstok to wcstok_s r=mhowell

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/59227967b5b5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9004931 [details]
Bug 1487126 Change uses of 3-argument wcstok to wcstok_s r=mhowell

MingW bustage fix from bug 1481907. Approved for ESR 60.2.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/0eb16d811e02