Closed
Bug 1487163
Opened 6 years ago
Closed 6 years ago
GetEGLTextureFormat function is unused
Categories
(Core :: Graphics: WebRender, enhancement, P5)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We have a function GetEGLTextureFormat which was added with 1 caller, and that caller was later removed, so it's now unused.
(clang-cl.exe spammed a warning to tell me this in a Windows build just now.)
Let's remove this dead code.
References:
- Function added with 1 caller here:
https://hg.mozilla.org/mozilla-central/rev/c39eda1b5bb35091ba15405dbec8d25de1957384
- That caller was removed here:
https://hg.mozilla.org/mozilla-central/rev/ac50a38689a0#l3.62
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Blocks: buildwarning
Priority: -- → P5
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9004968 [details]
Bug 1487163: Remove unused function GetEGLTextureFormat(). r=jgilbert
Jeff Gilbert [:jgilbert] has approved the revision.
Attachment #9004968 -
Flags: review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6f8a968931e
Remove unused function GetEGLTextureFormat(). r=jgilbert
|
||
Comment 4•6 years ago
|
||
Is it possible to remove AllowCompilerWarnings() from gfx/webrender_bindings/moz.build now?
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•