1487168 - clang-cl.exe warns that ShouldShowFocusRingIfFocusedByMouse() is unused on windows

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P5)

Description

[Daniel Holbert [:dholbert]]

When building with clang-cl.exe on Windows, I got a build warning that nsGlobalWindowInner.cpp's function "ShouldShowFocusRingIfFocusedByMouse" is unused (-Wunused-function).

This function only has one caller, which happens to be #ifndef XP_WIN.

Let's make its definition have that same guard, so that it's only defined on the platforms where it's called & so we don't get these unused function build warnings.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1487168: Give ShouldShowFocusRingIfFocusedByMouse() an #ifndef guard to match its caller & to avoid -Wunused-function build warning. r=smaug

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9004972 [details]
Bug 1487168: Give ShouldShowFocusRingIfFocusedByMouse() an #ifndef guard to match its caller & to avoid -Wunused-function build warning. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d6495af4aa9
Give ShouldShowFocusRingIfFocusedByMouse() an #ifndef guard to match its caller & to avoid -Wunused-function build warning. r=smaug

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1d6495af4aa9

Comment 5

[Masatoshi Kimura [:emk]]

Can I remove AllowCompilerWarnings() from dom/base/moz.build?

Comment 6

[Daniel Holbert [:dholbert]]

If it passes an all-platforms Try run, then it's presumably fine!

Comment 7

[Daniel Holbert [:dholbert]]

(Ah, I see that AllowCompilerWarnings() is clang-on-windows specific and is tagged as "workaround for bug 1090497".  I don't know offhand whether this was the last/only warning in that directory or not, so I don't know whether it's removable at this point.)