1487173 - Convert asan-reporter away from bootstrap

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Andrew Swan [:aswan]]

From IRC discussion with :decoder, steps for testing:

1. Create a build with both:
ac_add_options --enable-address-sanitizer-reporter
ac_add_options --enable-address-sanitizer

2. Run the browser and cause a content process crash (perhaps as simple as loading https://bug1419991.bmoattachments.org/attachment.cgi?id=8931181)

3. This should cause an asan crash report to be sent, the simple way to verify that happened is just checking for the logger statements from this function:
https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/extensions/asan-reporter/bootstrap.js#130

Comment 2

[Andrew Swan [:aswan]]

Christian, is there any reason this needs to remain a system add-on?  Can we just land it built-in (still with a build-time flag for whether to enable it or not)?

Comment 3

[Christian Holler (:decoder)]

(In reply to Andrew Swan [:aswan] from comment #2)
> Christian, is there any reason this needs to remain a system add-on?  Can we
> just land it built-in (still with a build-time flag for whether to enable it
> or not)?

What do you mean by built-in, you mean without being an extension of some sort at all? I think that would be ok if it doesn't spread the code around too much. Also, we would have to implement a way for people to figure out that they have the right build. Right now people look at about:support and there they see it has the ASan Reporter.

Comment 4

[Andrew Swan [:aswan]]

Yes, I meant converting away from an extension to a built-in feature.
To be sure I'm clear on this, is it required that we be able to produce ASAN builds both with and without the reporter?  Can the reporter just always be present in ASAN builds?  If that's not acceptable, what if it was always present but with a pref for turning it on and off?

Comment 5

[Christian Holler (:decoder)]

ASAn Reporter functionality is (and must remain) separate from the regular ASan build options. There is already --enable-address-sanitizer-reporter at build time to guard this and this flag could be used to guard built-in code as well.

In fact, ASan reporter already has some code builtin to Firefox (lower-level code) to make the reporting to profile directory even possible. I am fine with converting the rest to builtin code as well if that makes things easier for you.

However, we need a visual indicator somewhere (e.g. an easy way to check in about:support or something) that this is an ASan Reporter build.

Comment 6

[Andrew Swan [:aswan]]

Attachment: Bug 1487173 Switch asan-reporter to built-in

Comment 7

[Christian Holler (:decoder)]

Comment on attachment 9008247 [details]
Bug 1487173 Switch asan-reporter to built-in

Christian Holler (:decoder) has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d07de0b49710
Switch asan-reporter to built-in r=decoder

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d07de0b49710