148726 - White line in Modern urlbar

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stephen Walker]

There's a small white line running the entire length of the Modern urlbar.

Comment 1

[Stephen Walker]

Attachment: Screenshot

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

See http://home.bluemarble.net/~walk84/mozilla/urlbar.png

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Comparison (top is old, bottom is new)

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch, V1

Comment 5

[R.K.Aa.]

I thought that was by design, to give it a slight "sunken" /3D look? 
The alternative looks big and flat in comparision, I like the old one better.

Comment 6

[marlon bishop]

this is by design -> invalid

Comment 7

[Stephen Walker]

marlon, it's by design that there is an entirely different colored line going 
through an otherwise nice looking gradient? sounds like a bad design to me.

Comment 8

[John S. Musarra]

I see it. It's *very* subtle, I didn;t even see it until I had the screenshot to
show me what I was loking for.
2002060206 on Win98SE

Comment 9

[Bradley Lawrence]

I also see this. It is much more apparent on my laptop's LCD (particularily when
tilted wrong) than it is on my CRT (where it is nearly invisible).

If the white line was at the *very* bottom of the URL bar, I could imagine it
being by design, but it's not, it's slightly above the bottom, and has no 3d
aspects to it at all, it's just straight across and very flat. Interestingly
enough, the top of the line appears to be aligned with the 'baseline' of the
text (not counting characters that drop below baseline such as g, q, p, etc)

Anyway, it's trivial, but visible.

Comment 10

[R.K.Aa.]

*** Bug 235270 has been marked as a duplicate of this bug. ***

Comment 11

[timeless]

Comment on attachment 86014 [details] [diff] [review]
Patch, V1

who owns modern these days anyway? :)

Comment 12

[[e-mail]]

Comment on attachment 86014 [details] [diff] [review]
Patch, V1

Assuming MReimer doesn't respond before the next release, I suppose I could agree to this, assuming you a) use the full CSS property name b) remove the other reference to the file c) CVS remove the file too.

Comment 13

[Manuel Reimer]

I'm a bit busy, sorry for the late answer.

I'll have a look at this one as soon as possible.

Modern will be reworked completely as soon as the new "classic" (or better: default) theme is in a final state. I'll check if this patch is still needed in my "work in progress version" of modern.

Comment 14

[Samuel Sidler (old account; do not CC)]

Manuel, have you had a chance to look at this patch?

(Cleaning up old review requests.)

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

I totally disavow this bug, but thanks for the reminder, Sam :-)

Comment 16

[Philip Chee]

Attachment: Patch v1.0 use box-shadow instead.

Notes:
Introduced in 2001:
1.59 <[e-mail]> 2001-12-19 03:54
XUL/theme simplification changes - removing unnecessary boxes and re-writing large portions of the themes to use new -moz-border-colors and -moz-image-region css features. Also cleans up the classic skin quite a bit for both mac and win. Fixes bugs 113024, 113043, 113585, 113586, 115943, 113643, 114475, 99787, 110214, 113977, 113966, 114802, 64894, 90724, 103173, 103199, 103298, 110442, 111472, 111989, 113027, 113041, 109180, 109204, 81581, 81903, 103324, 110108, 114540, and probably more I forgot to mention. r=ben, sr=hyatt

My theory is that the top three white pixels in urlbar-mid.gif were meant to be transparent. This would create a subtle gradient.

Comment 17

[[e-mail]]

Comment on attachment 527943 [details] [diff] [review]
Patch v1.0 use box-shadow instead.

Review of attachment 527943 [details] [diff] [review]:

Interestingly you could easily restore the white line in userChrome.css by adding a second box shadow.

::: suite/themes/modern/navigator/navigator.css
@@ +521,5 @@
   -moz-border-left-colors: #A5ACB5 #000000 #A7BACA;
+  background-color: #EDF5F7;
+  box-shadow: inset 0px -2px #E9F3F6;
+/* XXXRatty: Alternative suggestion, looks better on a LCD screen.
+  box-shadow: inset 0px -3px #E9F0F2;

-3px looks wrong, because it overlaps the text (the old image only had two pixels of colour.) I can't tell any colour difference on my LCD monitor so I'd stick with the original colour too.

Comment 18

[Philip Chee]

Attachment: Patch v1.0a as pushed r=Neil

> -3px looks wrong, because it overlaps the text (the old image only had two
> pixels of colour.) I can't tell any colour difference on my LCD monitor so I'd
> stick with the original colour too.
OK. Removing commented block.

Pushed:
http://hg.mozilla.org/comm-central/rev/33f66df662a5
http://hg.mozilla.org/releases/comm-2.0/rev/aa944a2c23ee