1487261 - swagger-spec-validator v2.4.0 doesn't allow multiple types

Status: RESOLVED DUPLICATE of bug 1387064

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement)

Description

[Nick Thomas [:nthomas] (UTC+12)]

pyup opened https://github.com/mozilla/balrog/pull/772 but there are test failures.

py27: https://taskcluster-artifacts.net/VVQz42qvQn6lFiCgscRaFA/1/public/logs/live_backing.log

Might be hanging, or it might be test infra. I've rerun a few times so this needs further investigation.

py36: https://taskcluster-artifacts.net/cdAZLHBcSqKExhlfvOrPDA/0/public/logs/live_backing.log

____________ ERROR collecting auslib/test/admin/views/test_base.py _____________
auslib/test/admin/views/test_base.py:4: in <module>
    from auslib.test.admin.views.base import ViewTest
auslib/test/admin/views/base.py:8: in <module>
    from auslib.web.admin.base import app
auslib/web/admin/base.py:35: in <module>
    connexion_app.add_api(spec, validate_responses=True, strict_validation=True)
.tox/py36/lib/python3.6/site-packages/connexion/apps/flask_app.py:54: in add_api
    api = super(FlaskApp, self).add_api(specification, **kwargs)
.tox/py36/lib/python3.6/site-packages/connexion/apps/abstract.py:162: in add_api
    options=api_options.as_dict())
.tox/py36/lib/python3.6/site-packages/connexion/apis/abstract.py:104: in __init__
    self._validate_spec(spec)
.tox/py36/lib/python3.6/site-packages/connexion/apis/abstract.py:152: in _validate_spec
    validate_spec(spec)
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:97: in validate_spec
    validate_apis(apis, bound_deref)
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:310: in validate_apis
    idx=idx,
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:247: in validate_parameter
    validate_body_parameter(param, deref, def_name)
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:238: in validate_body_parameter
    visited_definitions_ids=set(),
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:406: in validate_definition
    visited_definitions_ids=visited_definitions_ids,
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:427: in validate_definition
    visited_definitions_ids=visited_definitions_ids,
.tox/py36/lib/python3.6/site-packages/swagger_spec_validator/validator20.py:398: in validate_definition
    raise SwaggerValidationError('type must be a string; lists are not allowed (%s)' % swagger_type)
E   swagger_spec_validator.common.SwaggerValidationError: type must be a string; lists are not allowed (['boolean', 'string'])

The spec validator changed in https://github.com/OAI/OpenAPI-Specification/issues/458 to prevent type definitions which are lists, which we use extensively.