Closed Bug 1487313 Opened 5 years ago Closed 5 years ago

stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y

Categories

(Core :: Disability Access APIs, task, P3)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

patch
1.76 KB, patch
Jamie
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
part of dexblization, see bug 1446830 comment 34 for details
Attachment #9005113 - Flags: review?(jteh)
Assignee: nobody → surkov.alexander
Comment on attachment 9005113 [details] [diff] [review]
patch

Review of attachment 9005113 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/xul/XULElementAccessibles.cpp
@@ -20,4 @@
>  #include "Logging.h"
>  #endif
>  
> -#include "nsIDOMXULDescriptionElement.h"

Heh, so we never actually used this interface anyway, just included the header?
Attachment #9005113 - Flags: review?(jteh) → review+
Priority: -- → P3
(In reply to James Teh [:Jamie] from comment #1)

> > -#include "nsIDOMXULDescriptionElement.h"
> 
> Heh, so we never actually used this interface anyway, just included the
> header?

I think it was used before, but now just artifact, hg history should have a story of it
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ce62b711b82
stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y, r=jamie
https://hg.mozilla.org/mozilla-central/rev/2ce62b711b82
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1446830
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.