stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
Posted patch patchSplinter Review
part of dexblization, see bug 1446830 comment 34 for details
Attachment #9005113 - Flags: review?(jteh)
Assignee

Updated

9 months ago
Assignee: nobody → surkov.alexander

Comment 1

9 months ago
Comment on attachment 9005113 [details] [diff] [review]
patch

Review of attachment 9005113 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/xul/XULElementAccessibles.cpp
@@ -20,4 @@
>  #include "Logging.h"
>  #endif
>  
> -#include "nsIDOMXULDescriptionElement.h"

Heh, so we never actually used this interface anyway, just included the header?
Attachment #9005113 - Flags: review?(jteh) → review+

Updated

9 months ago
Priority: -- → P3
Assignee

Comment 2

9 months ago
(In reply to James Teh [:Jamie] from comment #1)

> > -#include "nsIDOMXULDescriptionElement.h"
> 
> Heh, so we never actually used this interface anyway, just included the
> header?

I think it was used before, but now just artifact, hg history should have a story of it

Comment 3

9 months ago
Pushed by surkov.alexander@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ce62b711b82
stop using nsIDOMXULLabelElement and nsIDOMXULDescriptionElement in a11y, r=jamie

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ce62b711b82
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee

Updated

9 months ago
Blocks: 1446830
Blocks: 1448213
You need to log in before you can comment on or make changes to this bug.