Add common class for main browser window toolbars and replace #navigator-toolbox > toolbar selectors

RESOLVED FIXED in Firefox 63

Status

()

P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

63 Branch
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
Bug 1356920 wants to move the menu and tabs toolbars such that #navigator-toolbox > toolbar selectors wouldn't work anymore. We can prepare for this by using a common class for these toolbars. Even if bug 1356920 should change course, this seems like a reasonable simplification.
(Assignee)

Comment 1

4 months ago
Created attachment 9005136 [details] [diff] [review]
patch
Attachment #9005136 - Flags: review?(mconley)
Comment on attachment 9005136 [details] [diff] [review]
patch

Review of attachment 9005136 [details] [diff] [review]:
-----------------------------------------------------------------

This is great! Thanks for thinking ahead here.

::: browser/themes/shared/browser.inc.css
@@ +46,5 @@
>  }
>  
>  /* Bookmark toolbar */
>  
> +#PersonalToolbar {

Yes, this is much simpler. :)
Attachment #9005136 - Flags: review?(mconley) → review+

Comment 3

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ae749212402
Add common class for main browser window toolbars and replace #navigator-toolbox > toolbar selectors. r=mconley

Comment 4

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5ae749212402
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.