Closed Bug 1487344 Opened 5 years ago Closed 5 years ago

Add common class for main browser window toolbars and replace #navigator-toolbox > toolbar selectors

Categories

(Firefox :: Theme, enhancement, P2)

Product:
Firefox
Component:
Theme
Version:
63 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

patch
10.15 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
Bug 1356920 wants to move the menu and tabs toolbars such that #navigator-toolbox > toolbar selectors wouldn't work anymore. We can prepare for this by using a common class for these toolbars. Even if bug 1356920 should change course, this seems like a reasonable simplification.
Attached patch patch — — Splinter Review 

        Attachment #9005136 -
        Flags: review?(mconley)

    
    

    
  
Comment on attachment 9005136 [details] [diff] [review]
patch

Review of attachment 9005136 [details] [diff] [review]:
-----------------------------------------------------------------

This is great! Thanks for thinking ahead here.

::: browser/themes/shared/browser.inc.css
@@ +46,5 @@
>  }
>  
>  /* Bookmark toolbar */
>  
> +#PersonalToolbar {

Yes, this is much simpler. :)

        Attachment #9005136 -
        Flags: review?(mconley) → review+

    
    

    
  
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ae749212402
Add common class for main browser window toolbars and replace #navigator-toolbox > toolbar selectors. r=mconley

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5ae749212402
Status: ASSIGNED → RESOLVED
Closed: 5 years ago

          status-firefox63:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

          You need to log in
          before you can comment on or make changes to this bug.