1487346 - Shell module loader puts non-standard property on Reflect object

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

When the shell module loader is present it adds the Loader property on the global Reflect object.  At the moment this only happens when the shell executes a module, but that will change with dynamic import support since the module loader will be required for classic scripts too.

This extra property causes failures in tests that check the properties of the Reflect object are correct.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1487346-remove-module-loader-property

Path to remove this property and instead have the shell module loader call a special function to tell the shell how to load module graphs.

Comment 2

[André Bargull [:anba]]

Comment on attachment 9005178 [details] [diff] [review]
bug1487346-remove-module-loader-property

Review of attachment 9005178 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/afbecefb2def
Replace shell module loader property with a hook function r=anba

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19ae3c278414
Fix JS lint error on a CLOSED TREE r=me

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/afbecefb2def
https://hg.mozilla.org/mozilla-central/rev/19ae3c278414