Closed Bug 1487346 Opened Last year Closed Last year

Shell module loader puts non-standard property on Reflect object

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When the shell module loader is present it adds the Loader property on the global Reflect object.  At the moment this only happens when the shell executes a module, but that will change with dynamic import support since the module loader will be required for classic scripts too.

This extra property causes failures in tests that check the properties of the Reflect object are correct.
Path to remove this property and instead have the shell module loader call a special function to tell the shell how to load module graphs.
Attachment #9005178 - Flags: review?(andrebargull)
Comment on attachment 9005178 [details] [diff] [review]
bug1487346-remove-module-loader-property

Review of attachment 9005178 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #9005178 - Flags: review?(andrebargull) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/afbecefb2def
Replace shell module loader property with a hook function r=anba
https://hg.mozilla.org/mozilla-central/rev/afbecefb2def
https://hg.mozilla.org/mozilla-central/rev/19ae3c278414
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.