1487371 - [Mac] Enter key triggers no response inside the permission doorhangers when Tab navigation is used

Status: NEW

(Firefox :: Site Permissions, defect, P3)

Description

[Anca Soncutean, Desktop QA]

[Affected versions]: 
- 62.0 (201808271444249)
- 63.0b1 Dev edition (20180824192747)
- 63.0a1 (20180830010250)

[Affected platforms]:
- macOS 10.13

[Steps to reproduce]:
1. Open about:addons
2. Choose any addon and activate the button next to it
3. Press the Tab key in order to navigate to Cancel/Add buttons
4. Press the Enter key

[Expected result]:
- The corresponding (Cancel/Add) actions are performed, once the Enter key is pressed

[Actual result]:
- No action is triggered when pressing the Enter key

[Regression range]: 
- Not a regression, this issue is reproducible way back to Nightly 55.0a1 (20170324030205), when the add-on doorhanger UI with the current buttons was implemented 

[Additional Notes]:
- This behavior can be also seen on notification/location permission doorhangers, but note here that Never allow button displays its label when Enter key is pressed
- Mac versions 10.11 and 10.12 are not affected, I couldn’t use the tab navigation
- On Ubuntu and Windows platform the keywords (Tab and Enter) work as expected

Comment 1

[Andrew Swan [:aswan]]

For me, on MacOS 10.13.6, pressing the tab key does not highlight any buttons in a doorhanger so I can't get past step 3.
In any case, given the additional note, this sounds like a PopupNotifcations issue...

Comment 2

[Johann Hofmann [:johannh]]

Yup, the enter key doesn't select these options on OSX. Space does. If enter works on Windows and Linux we might want to make it consistent.

> - Mac versions 10.11 and 10.12 are not affected, I couldn’t use the tab navigation

I don't understand this point. Are you saying that 10.11 and 10.12 work fine or that you couldn't use tab navigation at all?

(In reply to Andrew Swan [:aswan] from comment #1)
> For me, on MacOS 10.13.6, pressing the tab key does not highlight any
> buttons in a doorhanger so I can't get past step 3.
> In any case, given the additional note, this sounds like a PopupNotifcations
> issue...

You have to go to System Preferences > Keyboard > Shortcuts > Full Keyboard Access and select "All controls"