1487390 - Notify when a channel is aborted because of fastblocking

Status: RESOLVED FIXED

(Core :: Security, defect, P1)

Description

[Andrea Marchesini [:baku]]

The notification could be nsIWebProgressListener::STATE_FAST_BLOCKED.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fastBlock.patch

Comment 2

[(no longer active)]

Comment on attachment 9005191 [details] [diff] [review]
fastBlock.patch

Review of attachment 9005191 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/base/nsIWebProgressListener.idl
@@ +315,5 @@
>    const unsigned long STATE_COOKIES_BLOCKED_BY_PERMISSION = 0x10000000;
>    const unsigned long STATE_COOKIES_BLOCKED_TRACKER       = 0x20000000;
>    const unsigned long STATE_COOKIES_BLOCKED_ALL           = 0x40000000;
>    const unsigned long STATE_COOKIES_BLOCKED_FOREIGN       = 0x80000000;
> +  const unsigned long STATE_FAST_BLOCKED                  = 0x00000040;

This name doesn't read too well...  How about calling it STATE_BLOCKED_SLOW_TRACKING_CONTENT (similar to STATE_BLOCKED_TRACKING_CONTENT)?

Also can you add a comment right after STATE_LOADED_MIXED_ACTIVE_CONTENT saying 0x00000040 is used further down?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37133ece7ce2
Notify when a channel is aborted because of fastblocking, r=ehsan

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/37133ece7ce2