Closed Bug 1487557 Opened 1 year ago Closed 1 year ago

Make all rows of active policies to have the same number of columns

Categories

(Firefox :: Enterprise Policies, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: Felipe, Assigned: soeren.hentzschel, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Right now, different policies generates different number of columns in the Active policies table, and there isn't a simple way through CSS to fill the background in the missing columns.

The simple policies (e.g. just a boolean flag) have two columns, and most other policies have 3, but it's possible to have an array policy with just two columns too, and the Permissions policy have 4.

Bug 1483431 improves on this situation by always creating a 3rd column for simple policies, but it still doesn't cover all possibilities. (I'll attach a screenshot and a sample.json file to make it easier to see).

Keeping tracking of this in the recursive function is one solution, but that seems too complicated.

However, there is one simpler solution: _after_ all policies are created in the table, there can be a function that goes through the table and sees what was the max number of columns, and then goes filling the rows with empty <td>s where there's not enough.
Attached file sample.json
Sören, are you interested on this one too?
Mentor: felipc
Flags: needinfo?(cadeyrn)
Yes, I can take this.
Flags: needinfo?(cadeyrn)
Assignee: nobody → cadeyrn
Status: NEW → ASSIGNED
Comment on attachment 9005514 [details]
Bug 1487557 - Make all rows of active policies to have the same number of columns

:Felipe Gomes (needinfo me!) has approved the revision.
Attachment #9005514 - Flags: review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfe71056fd0f
Make all rows of active policies to have the same number of columns. r=felipe
https://hg.mozilla.org/mozilla-central/rev/bfe71056fd0f
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
This issue is verified fixed using Firefox 63.0b11 (BuildId:20181001131022) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.