1487557 - Make all rows of active policies to have the same number of columns

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Right now, different policies generates different number of columns in the Active policies table, and there isn't a simple way through CSS to fill the background in the missing columns.

The simple policies (e.g. just a boolean flag) have two columns, and most other policies have 3, but it's possible to have an array policy with just two columns too, and the Permissions policy have 4.

Bug 1483431 improves on this situation by always creating a 3rd column for simple policies, but it still doesn't cover all possibilities. (I'll attach a screenshot and a sample.json file to make it easier to see).

Keeping tracking of this in the recursive function is one solution, but that seems too complicated.

However, there is one simpler solution: _after_ all policies are created in the table, there can be a function that goes through the table and sees what was the max number of columns, and then goes filling the rows with empty <td>s where there's not enough.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: sample.json

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screen Shot 2018-08-30 at 7.34.26 PM.png

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Sören, are you interested on this one too?

Comment 4

[Sören Hentzschel]

Yes, I can take this.

Comment 5

[Sören Hentzschel]

Attachment: Bug 1487557 - Make all rows of active policies to have the same number of columns

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9005514 [details]
Bug 1487557 - Make all rows of active policies to have the same number of columns

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfe71056fd0f
Make all rows of active policies to have the same number of columns. r=felipe

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bfe71056fd0f

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 63.0b11 (BuildId:20181001131022) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.