Closed Bug 1487559 Opened 6 years ago Closed 6 years ago

add new telemetry probe for the content policy causing suspension for back pressure

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

to investigate the high suspension rate
Assignee: nobody → juhsu
The addition of a data collection is subject to Data Collection Review: https://wiki.mozilla.org/Firefox/Data_Collection
Let's see what telemetry from bug 1494133 says before going for this.

We may want this code to run only on nightly and early-beta.
Can you use nsContentPolicyType instead of parsing content-type?
(In reply to Dragana Damjanovic [:dragana] from comment #3)
> Let's see what telemetry from bug 1494133 says before going for this.
> 
> We may want this code to run only on nightly and early-beta.

Okay, the review request is removed.

> Can you use nsContentPolicyType instead of parsing content-type?

Yes, it's simpler
Summary: add new telemetry probe for the mime type causing suspension for back pressure → add new telemetry probe for the content policy causing suspension for back pressure
Attached file Request_1487559.txt
data-r?
Attachment #9018416 - Flags: review?(francois)
Comment on attachment 9018416 [details]
Request_1487559.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Not yet, see my comments in the other patch.

Please r? me again once that is fixed.
Attachment #9018416 - Flags: review?(francois) → review-
Comment on attachment 9018416 [details]
Request_1487559.txt

data-r? again for attachment 9005520 [details] change
Attachment #9018416 - Flags: review- → review?(francois)
Comment on attachment 9018416 [details]
Request_1487559.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON in pre-release channels only.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are fine.
Attachment #9018416 - Flags: review?(francois) → review+
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7fe04d00e18
add new telemetry probe for the mime type causing suspension for back pressure r=francois,valentin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f7fe04d00e18
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.