1487559 - add new telemetry probe for the content policy causing suspension for back pressure

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Junior [inactive]]

to investigate the high suspension rate

Comment 1

[Junior [inactive]]

Attachment: Bug 1487559 - add new telemetry probe for the mime type causing suspension for back pressure

Comment 2

[Jan-Erik Rediger [:janerik]]

The addition of a data collection is subject to Data Collection Review: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 3

[Dragana Damjanovic [:dragana]]

Let's see what telemetry from bug 1494133 says before going for this.

We may want this code to run only on nightly and early-beta.

Comment 4

[Dragana Damjanovic [:dragana]]

Can you use nsContentPolicyType instead of parsing content-type?

Comment 5

[Junior [inactive]]

(In reply to Dragana Damjanovic [:dragana] from comment #3)
> Let's see what telemetry from bug 1494133 says before going for this.
> 
> We may want this code to run only on nightly and early-beta.

Okay, the review request is removed.

> Can you use nsContentPolicyType instead of parsing content-type?

Yes, it's simpler

Comment 6

[Junior [inactive]]

Attachment: Request_1487559.txt

data-r?

Comment 7

[François Marier [:francois]]

Comment on attachment 9018416 [details]
Request_1487559.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Not yet, see my comments in the other patch.

Please r? me again once that is fixed.

Comment 8

[Junior [inactive]]

Comment on attachment 9018416 [details]
Request_1487559.txt

data-r? again for attachment 9005520 [details] change

Comment 9

[Junior [inactive]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=825f7a687e118d99f46c2c99ada7b7524d6f84ac

Comment 10

[François Marier [:francois]]

Comment on attachment 9018416 [details]
Request_1487559.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON in pre-release channels only.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are fine.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7fe04d00e18
add new telemetry probe for the mime type causing suspension for back pressure r=francois,valentin

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f7fe04d00e18