1487606 - AppendLiteral after SetCapacity() undoes the effect of SetCapacity()

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Henri Sivonen (:hsivonen)]

When mLength == 0, AppendLiteral() ends up calling AssignLiteral(). This is bad if SetCapacity() was called before AppendLiteral() and the caller in good faith assumed that SetCapacity() before a sequence of appends is OK.

AppendLiteral() should not call AssignLiteral() if mLength == 0 and the string already has a shared buffer.

Comment 1

[Henri Sivonen (:hsivonen)]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=59e6d610f65984b21000c0d5a67bbdebe461ab6b

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1487606 - Make AppendLiteral() not undo the effect of SetCapacity().

MozReview-Commit-ID: I2QSXbQhOUH

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 9005583 [details]
Bug 1487606 - Make AppendLiteral() not undo the effect of SetCapacity().

Nathan Froyd [:froydnj] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf6f5ec86920
Make AppendLiteral() not undo the effect of SetCapacity(). r=froydnj

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bf6f5ec86920