Closed Bug 1487649 Opened 1 year ago Closed 1 year ago

Print (preview) error triggered for certain SVG samples

Categories

(Core :: Print Preview, defect)

63 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: JuliaC, Assigned: emilio)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Affected versions]:
- Devedition 63.0b2 build1 (20180830123124) 

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- MacOS 10.11.6

[Steps to reproduce]:
1. Launch Firefox
2. Open http://upload.wikimedia.org/wikipedia/en/c/ce/SVG-logo.svg 
3. Access the Print command (or open the Print Preview, if available)

[Expected result]:
- The Print (Print Preview) menu is successfully opened and the user is able to properly print the sample

[Actual result]:
- "Printer Error" (Print Preview Error") is displayed (see the following screenshots https://drive.google.com/file/d/1PzYoXlf-kfDNGc9ZfVEMjwygBr_LoZzn/view?usp=sharing and https://drive.google.com/file/d/1FK-hGAVxnxgxFVDTlY4PrrghNz7iS9R9/view?usp=sharing)
- The printing process cannot be finalized 

[Regression range]:
- Last good revision: 38e729d91ed2873b708bd4800b01b8433ffceabd
- First bad revision: 453d0a08f00c125ff6cc3905265e76efe641524e
- Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=38e729d91ed2873b708bd4800b01b8433ffceabd&tochange=453d0a08f00c125ff6cc3905265e76efe641524e
- It seems that Bug 1450250 regressed this issue
Thanks for finding this :)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)
Otherwise the ShadowRoot for <use> or other internal ones may not get cloned
properly.
Comment on attachment 9005598 [details]
Don't do a name check when cloning a shadow root for print preview.

Olli Pettay [:smaug] has approved the revision.
Attachment #9005598 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/65b36a89443f
Don't do a name check when cloning a shadow root for print preview. r=smaug
Thanks Andreea :)
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/5254a8f44df4
Don't do a name check when cloning a shadow root for print preview. r=smaug
https://hg.mozilla.org/mozilla-central/rev/5254a8f44df4
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
See Also: → 1500812
You need to log in before you can comment on or make changes to this bug.