1487649 - Print (preview) error triggered for certain SVG samples

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- Devedition 63.0b2 build1 (20180830123124) 

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- MacOS 10.11.6

[Steps to reproduce]:
1. Launch Firefox
2. Open http://upload.wikimedia.org/wikipedia/en/c/ce/SVG-logo.svg 
3. Access the Print command (or open the Print Preview, if available)

[Expected result]:
- The Print (Print Preview) menu is successfully opened and the user is able to properly print the sample

[Actual result]:
- "Printer Error" (Print Preview Error") is displayed (see the following screenshots https://drive.google.com/file/d/1PzYoXlf-kfDNGc9ZfVEMjwygBr_LoZzn/view?usp=sharing and https://drive.google.com/file/d/1FK-hGAVxnxgxFVDTlY4PrrghNz7iS9R9/view?usp=sharing)
- The printing process cannot be finalized 

[Regression range]:
- Last good revision: 38e729d91ed2873b708bd4800b01b8433ffceabd
- First bad revision: 453d0a08f00c125ff6cc3905265e76efe641524e
- Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=38e729d91ed2873b708bd4800b01b8433ffceabd&tochange=453d0a08f00c125ff6cc3905265e76efe641524e
- It seems that Bug 1450250 regressed this issue

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Thanks for finding this :)

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Don't do a name check when cloning a shadow root for print preview.

Otherwise the ShadowRoot for <use> or other internal ones may not get cloned
properly.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9005598 [details]
Don't do a name check when cloning a shadow root for print preview.

Olli Pettay [:smaug] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65b36a89443f
Don't do a name check when cloning a shadow root for print preview. r=smaug

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing mochitest chrome at layout/base/tests/chrome/test_printpreview.xul

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f6753d3d9db1ff69ae3a0d4f053412bbbc92e1fa

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196951691&repo=autoland&lineNumber=2647

Backout: https://hg.mozilla.org/integration/autoland/rev/80a2b4e9547cb80289ae49e6a7dc98345addb4d0

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Thanks Andreea :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5254a8f44df4
Don't do a name check when cloning a shadow root for print preview. r=smaug

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5254a8f44df4