Closed Bug 1487856 Opened 2 years ago Closed 2 years ago
"No Style" function doesn't disable HTML "style" attributes
46 bytes, text/x-phabricator-request
|Details | Review|
You're right, this is a Stylo regression. Should be pretty easy to fix.
Assignee: nobody → emilio
Status: UNCONFIRMED → NEW
Ever confirmed: true
This also removes one of my FIXMEs from when I was looking at this code. We don't seem to have a pre-existing test for this feature, sigh. I'll try to write one if I have cycles for it... Note that it not applying XBL rules is a feature, given the current state of affairs. Video controls and such are right now unusable with no styles enabled.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #2) > Note that it not applying XBL rules is a feature, given the current state of > affairs. Video controls and such are right now unusable with no styles > enabled. Is there a bug on file for this?
Comment on attachment 9005716 [details] Make the author styles disabled stuff actually disable style attribute, animations, and XBL rules. Cameron McCormack (:heycam) has approved the revision.
Attachment #9005716 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5aa8199bc161 Make the author styles disabled stuff actually disable style attribute, animations, and XBL rules. r=heycam
This fixes a regression, please push to ESR.
I have reproduced this issue using Firefox 63.0a1 (2018.08.31) on Windows 10 x64. Verified on ESR 52.9.0 it works. I can confirm this issue is fixed, I verified using Firefox 63.0b5 on Ubuntu 16.04 x64, Windows 10 x64 and Mac OS X 10.14.
See comment #7.
I'd need to rebase the patch, and I'd be happy to if needed. Though but I honestly don't think it's a particularly good candidate for ESR uplift. I don't think it's critical and this has been the only report of it since FF 57 (which is when this broke). But you're welcome to make a case if you think it is, and a request toggling the attachment details and setting the approval-mozilla-esr flag to '?' so that the people that decide whether to uplift this or not have the right information. Thanks for the report.
You need to log in before you can comment on or make changes to this bug.