Closed Bug 1487954 Opened 6 years ago Closed 6 years ago

Intermittent devtools/client/framework/test/browser_toolbox_window_reload_target.js | Test timed out -

Categories

(DevTools :: Framework, defect, P2)

Product:
DevTools
Component:
Framework
Version:
63 Branch
Type:
defect

Tracking

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: yzen)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell disable-recommended])

Attachments

(1 file)

Bug 1487954 - do not load inspector unnecessarily when a11y panel is loaded. r=pbro
46 bytes, text/x-phabricator-request
pbro
: review+
pascalc
: approval-mozilla-beta+
Details | Review 
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=197003569&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/IVrnrxBmQPafrKmw-fUi8Q/runs/0/artifacts/public/logs/live_backing.log

task 2018-09-01T02:42:14.750Z] 02:42:14     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 5
[task 2018-09-01T02:42:14.751Z] 02:42:14     INFO - Buffered messages logged at 02:39:14
[task 2018-09-01T02:42:14.752Z] 02:42:14     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 4
[task 2018-09-01T02:42:14.753Z] 02:42:14     INFO - Buffered messages logged at 02:39:59
[task 2018-09-01T02:42:14.754Z] 02:42:14     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 3
[task 2018-09-01T02:42:14.755Z] 02:42:14     INFO - Buffered messages logged at 02:40:44
[task 2018-09-01T02:42:14.756Z] 02:42:14     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2018-09-01T02:42:14.758Z] 02:42:14     INFO - Buffered messages logged at 02:41:27
[task 2018-09-01T02:42:14.759Z] 02:42:14     INFO - Console message: [JavaScript Error: "NetworkError when attempting to fetch resource."]
[task 2018-09-01T02:42:14.760Z] 02:42:14     INFO - get@resource://services-settings/remote-settings.js:326:9
[task 2018-09-01T02:42:14.761Z] 02:42:14     INFO - async*getSite@resource://activity-stream/lib/FaviconFeed.jsm:158:25
[task 2018-09-01T02:42:14.762Z] 02:42:14     INFO - async*fetchIcon@resource://activity-stream/lib/FaviconFeed.jsm:132:24
[task 2018-09-01T02:42:14.763Z] 02:42:14     INFO - async*onAction@resource://activity-stream/lib/FaviconFeed.jsm:182:9
[task 2018-09-01T02:42:14.764Z] 02:42:14     INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
[task 2018-09-01T02:42:14.765Z] 02:42:14     INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
[task 2018-09-01T02:42:14.766Z] 02:42:14     INFO - _requestRichIcon@resource://activity-stream/lib/TopSitesFeed.jsm:461:5
[task 2018-09-01T02:42:14.767Z] 02:42:14     INFO - _fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:425:5
[task 2018-09-01T02:42:14.768Z] 02:42:14     INFO - async*getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:330:11
[task 2018-09-01T02:42:14.769Z] 02:42:14     INFO - async*refresh@resource://activity-stream/lib/TopSitesFeed.jsm:353:25
[task 2018-09-01T02:42:14.770Z] 02:42:14     INFO - async*onAction@resource://activity-stream/lib/TopSitesFeed.jsm:653:9
[task 2018-09-01T02:42:14.771Z] 02:42:14     INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
[task 2018-09-01T02:42:14.772Z] 02:42:14     INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
[task 2018-09-01T02:42:14.773Z] 02:42:14     INFO - init/this.intervalId<@resource://activity-stream/lib/SystemTickFeed.jsm:18:41
[task 2018-09-01T02:42:14.774Z] 02:42:14     INFO - notify@resource://gre/modules/Timer.jsm:42:7
[task 2018-09-01T02:42:14.775Z] 02:42:14     INFO - 
[task 2018-09-01T02:42:14.776Z] 02:42:14     INFO - Buffered messages logged at 02:41:29
[task 2018-09-01T02:42:14.777Z] 02:42:14     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2018-09-01T02:42:14.778Z] 02:42:14     INFO - Buffered messages finished
[task 2018-09-01T02:42:14.779Z] 02:42:14     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_window_reload_target.js | Test timed out - 
[task 2018-09-01T02:42:14.780Z] 02:42:14     INFO - GECKO(2183) | console.error: (new TypeError("currentPanel is undefined, can't access property \"stopPicker\" of it", "resource://devtools/shared/base-loader.js -> resource://devtools/client/framework/toolbox.js", 2795))
[task 2018-09-01T02:42:14.781Z] 02:42:14     INFO - Removing tab.
[task 2018-09-01T02:42:14.783Z] 02:42:14     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-09-01T02:42:14.784Z] 02:42:14     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-09-01T02:42:14.785Z] 02:42:14     INFO - Tab removed and finished closing
[task 2018-09-01T02:42:14.787Z] 02:42:14     INFO - GECKO(2183) | MEMORY STAT | vsize 8605MB | residentFast 470MB | heapAllocated 120MB
[task 2018-09-01T02:42:14.788Z] 02:42:14     INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_window_reload_target.js | took 450450ms
[task 2018-09-01T02:42:14.789Z] 02:42:14     INFO - checking window state
[task 2018-09-01T02:42:14.790Z] 02:42:14     INFO - TEST-START | devtools/client/framework/test/browser_toolbox_window_shortcuts.js
[task 2018-09-01T02:42:16.553Z] 02:42:16     INFO - GECKO(2183) | [ACTION] SET_WORKERS  - {"type":"SET_WORKERS","workers":[]}
[task 2018-09-01T02:42:16.554Z] 02:42:16     INFO - GECKO(2183) | [ACTION] CONNECT  - {"type":"CONNECT","url":"about:blank","canRewind":false}
[task 2018-09-01T02:42:16.570Z] 02:42:16     INFO - GECKO(2183) | [ACTION] PAUSE_ON_EXCEPTIONS [start] - {"type":"PAUSE_ON_EXCEPTIONS","shouldPauseOnExceptions":false,"shouldPauseOnCaughtExceptions":true,"seqId":"1","status":"start"}
[task 2018-09-01T02:42:16.571Z] 02:42:16     INFO - GECKO(2183) | [ACTION] PAUSE_ON_EXCEPTIONS [done] - {"type":"PAUSE_ON_EXCEPTIONS","shouldPauseOnExceptions":false,"shouldPauseOnCaughtExceptions":true,"seqId":"1","status":"done","value":{"from":"server1.conn13.child1/context24","type":"paused","actor":"server1.conn13.child1/pause37","poppedFrames":[],"why":{"type":"interrupted"}}}
[task 2018-09-01T02:42:16.672Z] 02:42:16     INFO - GECKO(2183) | [ACTION] SET_ORIENTATION  - {"type":"SET_ORIENTATION","orientation":"horizontal"}
[task 2018-09-01T02:42:17.933Z] 02:42:17     INFO - GECKO(2183) | MEMORY STAT | vsize 8619MB | residentFast 520MB | heapAllocated 174MB
[task 2018-09-01T02:42:17.933Z] 02:42:17     INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_window_shortcuts.js | took 3177ms
[task 2018-09-01T02:42:17.969Z] 02:42:17     INFO - checking window state
There have been 95 failures in the last week
Summary: Intermittent devtools/client/framework/test/browser_toolbox_window_reload_target.js | Test timed out -

Recent relevant log file:
https://treeherder.mozilla.org/logviewer.html#?job_id=198530918&repo=autoland&lineNumber=2101

Failures per platform and build type:

- linux64 / all builds: 42
- windows7-32 / pgo: 12
- windows10-64 / debug & debug: 11
- linux32 / opt: 10
- windows10-64-ccov / debug: 9
- osx-10-10 / debug & opt: 8
- linux64-nightly / opt: 2
- linux32-nightly / opt: 1
Flags: needinfo?(pbrosset)
Whiteboard: [retriggered] → [retriggered][stockwell needswork]
Alex, Yura, it seems (from comment 1) that this started when we enabled the a11y panel by default. Do you mind looking into this very frequent intermittent please?
Flags: needinfo?(yzenevich)
Flags: needinfo?(poirot.alex)
Flags: needinfo?(pbrosset)
Priority: P5 → P2
Will take this
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Flags: needinfo?(yzenevich)
The issue seemed to be due to the fact that a11y panel would load inspector tool, even though it just needed an inspector front. That resulted in intermitent issue where promise for getting the root node during inspector initialization not resolving because the root node deferred would get replaced while running the tests.
Comment on attachment 9008488 [details]
Bug 1487954 - do not load inspector unnecessarily when a11y panel is loaded. r=pbro

Patrick Brosset <:pbro> has approved the revision.
Attachment #9008488 - Flags: review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a238b0434c97
do not load inspector unnecessarily when a11y panel is loaded. r=pbro
https://hg.mozilla.org/mozilla-central/rev/a238b0434c97
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Please request Beta approval on this when you get a chance.
status-firefox63: --- → affected
Flags: needinfo?(yzenevich)
Comment on attachment 9008488 [details]
Bug 1487954 - do not load inspector unnecessarily when a11y panel is loaded. r=pbro

[Feature/Bug causing the regression]:  Caused by bug 1482454
[User impact if declined]: High frequency intermittent test failure in Devtools b-c.
[Is this code covered by automated tests?]: Yes, intermittent test failures stopped.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Fixed a regression that resulted in frequent intermittent.
[String changes made/needed]: None
Flags: needinfo?(yzenevich)
Attachment #9008488 - Flags: approval-mozilla-beta?
Comment on attachment 9008488 [details]
Bug 1487954 - do not load inspector unnecessarily when a11y panel is loaded. r=pbro

Uplift approved for 63 beta 7, thanks.
Attachment #9008488 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox62: --- → unaffected
status-firefox-esr60: --- → unaffected
Version: unspecified → 63 Branch
Flags: needinfo?(poirot.alex)
Blocks: 1497348
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: