1487989 - webdriver: Deref the matched expression instead of each variant

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

When matching we can dereference the expression we match on instead
of prefixing each variant with &:

> match self {
>     &NewSessionParameters::Spec(ref x) => x.match_browser(browser_capabilities),
>     &NewSessionParameters::Legacy(ref x) => x.match_browser(browser_capabilities),
> }

Instead:

> match *self {
>     NewSessionParameters::Spec(ref x) => x.match_browser(browser_capabilities),
>     NewSessionParameters::Legacy(ref x) => x.match_browser(browser_capabilities),
> }

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: deref matched expressions

Instead of accessing each variant using a reference, we should
dereference the matched expression when possible.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please see bug 1465381 for how it should be done. Also I think if you make your commit message that generic, please also check the remaining code of webdriver for updates. I barely believe this is the only place which needs an update.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: deref matched expressions

Instead of accessing each variant using a reference, we should
dereference the matched expression when possible.

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #2)

> Also I think if you make your commit message that generic, please
> also check the remaining code of webdriver for updates. I barely
> believe this is the only place which needs an update.

These were the only two cases clippy complained about, and I didn’t
find any other when inspecting the code by hand.  But you’re welcome
to have a look:
https://searchfox.org/mozilla-central/search?q=%5Cs%7B4%7Dmatch%5Cs&case=false&regexp=true&path=testing%2Fwebdriver%2F**%2F*.rs

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9005991 [details] [diff] [review]
webdriver: deref matched expressions

Review of attachment 9005991 [details] [diff] [review]:
-----------------------------------------------------------------

No, I think you are right and this looks fine. Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a41ca05867b
webdriver: deref matched expressions; r=whimboo

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5a41ca05867b