1488007 - mozversion: Fix clippy lints

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

Per title.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: mozversion: lint

Address clippy lint warnings in mozversion.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: mozversion: format

No functional changes, except applying rustfmt.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 9005844 [details] [diff] [review]
mozversion: format

Review of attachment 9005844 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/rust/mozversion/src/lib.rs
@@ +118,5 @@
>          if let Some(captures) = version_re.captures(version_string) {
> +            match captures
> +                .name("major")
> +                .and_then(|x| u64::from_str(x.as_str()).ok())
> +            {

I hadn't considered the possibility that someone might invent a style where the { sometimes goes on a new line and sometimes not. That's impressively ugly.

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to James Graham [:jgraham] from comment #3)

> ::: testing/mozbase/rust/mozversion/src/lib.rs
> @@ +118,5 @@
> >          if let Some(captures) = version_re.captures(version_string) {
> > +            match captures
> > +                .name("major")
> > +                .and_then(|x| u64::from_str(x.as_str()).ok())
> > +            {
> 
> I hadn't considered the possibility that someone might invent a style where
> the { sometimes goes on a new line and sometimes not. That's impressively
> ugly.

I see what you mean, but I think it happens to not give the impression
the new block is a continuation of the chained expression.

Compare for eaxmple:

> match captures
>     .name("major")
>     .and_then(|x| u64::from_str(x.as_str()).ok())
> {
>     new_block();
> }

To:

> match captures
>     .name("major")
>     .and_then(|x| u64::from_str(x.as_str()).ok()) {
>     new_block();
> }

However I think maybe we can avoid this altogether by splitting
this expression up.  I will do that in the patch I push.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Actually I won’t because this code is a bit complicated.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52af3a20610d
mozversion: lint; r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/66a735968247
mozversion: format; r=jgraham

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/52af3a20610d
https://hg.mozilla.org/mozilla-central/rev/66a735968247