Closed Bug 1488115 Opened 6 years ago Closed 6 years ago

Remove the XPCOM component registration for nsUTF8ConverterService

Categories

(Core :: Internationalization, enhancement)

Product:
Core
Component:
Internationalization
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Bug 1488115 - Part 1: Remove nsIUTF8ConverterService::ConvertURISpecToUTF8() since it is unused; r=hsivonen
46 bytes, text/x-phabricator-request
hsivonen
: review+
Details | Review
Bug 1488115 - Part 2: Replace the usage of nsUTF8ConverterService in nsCookie.cpp with the mozilla/Encoding.h API; r=hsivonen
46 bytes, text/x-phabricator-request
hsivonen
: review+
Details | Review
Bug 1488115 - Part 3: Move nsIUTF8ConverterService::ConvertStringToUTF8() to nsMIMEHeaderParamImpl.cpp since that is the only consumer site; r=hsivonen
46 bytes, text/x-phabricator-request
hsivonen
: review+
Details | Review
Bug 1488115 - Part 4: Remove nsUTF8ConverterService; r=hsivonen
46 bytes, text/x-phabricator-request
hsivonen
: review+
Details | Review
No description provided.
Comment on attachment 9005933 [details] Bug 1488115 - Remove the XPCOM component registration for nsUTF8ConverterService; r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9005933 - Flags: review+
Comment on attachment 9005933 [details] Bug 1488115 - Remove the XPCOM component registration for nsUTF8ConverterService; r=hsivonen Henri Sivonen (:hsivonen) has requested changes to the revision.
Attachment #9005933 - Flags: review+
Attachment #9005933 - Attachment is obsolete: true
Comment on attachment 9006024 [details] Bug 1488115 - Part 1: Remove nsIUTF8ConverterService::ConvertURISpecToUTF8() since it is unused; r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9006024 - Flags: review+
Comment on attachment 9006025 [details] Bug 1488115 - Part 2: Replace the usage of nsUTF8ConverterService in nsCookie.cpp with the mozilla/Encoding.h API; r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9006025 - Flags: review+
Comment on attachment 9006026 [details] Bug 1488115 - Part 3: Move nsIUTF8ConverterService::ConvertStringToUTF8() to nsMIMEHeaderParamImpl.cpp since that is the only consumer site; r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9006026 - Flags: review+
Comment on attachment 9006027 [details] Bug 1488115 - Part 4: Remove nsUTF8ConverterService; r=hsivonen Henri Sivonen (:hsivonen) has approved the revision.
Attachment #9006027 - Flags: review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a77fe76c4565 Part 1: Remove nsIUTF8ConverterService::ConvertURISpecToUTF8() since it is unused; r=hsivonen https://hg.mozilla.org/integration/mozilla-inbound/rev/776d6c8974ef Part 2: Replace the usage of nsUTF8ConverterService in nsCookie.cpp with the mozilla/Encoding.h API; r=hsivonen https://hg.mozilla.org/integration/mozilla-inbound/rev/7b3729ae7c46 Part 3: Move nsIUTF8ConverterService::ConvertStringToUTF8() to nsMIMEHeaderParamImpl.cpp since that is the only consumer site; r=hsivonen https://hg.mozilla.org/integration/mozilla-inbound/rev/c334f246f6ee Part 4: Remove nsUTF8ConverterService; r=hsivonen
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: