Closed Bug 1488118 Opened 2 years ago Closed 2 years ago

Sidebar splitter color is wrong when sidebar is placed on right side

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- verified
firefox64 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

(Keywords: regression)

Attachments

(2 files)

No description provided.
Assignee: nobody → ntim.bugs
Keywords: regression
Comment on attachment 9005937 [details]
Bug 1488118 - Fix sidebar border color when it's on the right. r=dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9005937 - Flags: review+
Priority: -- → P1
Attachment #9005937 - Attachment description: Bug 1488118 - Fix sidebar border color when it's on the right. r=jaws → Bug 1488118 - Fix sidebar border color when it's on the right. r=dao
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/de3ad2046aa5
Fix sidebar border color when it's on the right. r=dao
https://hg.mozilla.org/mozilla-central/rev/de3ad2046aa5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Please request Beta approval on this when you get a chance.
Flags: needinfo?(ntim.bugs)
Comment on attachment 9005937 [details]
Bug 1488118 - Fix sidebar border color when it's on the right. r=dao

Approval Request Comment
[Feature/Bug causing the regression]: bug 1484891
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: somewhat
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]:  see comment 0
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: 1 line CSS change
[String changes made/needed]:
Flags: needinfo?(ntim.bugs)
Attachment #9005937 - Flags: approval-mozilla-beta?
Comment on attachment 9005937 [details]
Bug 1488118 - Fix sidebar border color when it's on the right. r=dao

Approved for 63 Beta 4
Attachment #9005937 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reproduced the issue on Nightly 64 09-04-2018 on Windows and OSX. 
Verified as fixed on Nightly 64 09-07-2018 and 63 beta 4 on Windows 10, Osx 10.13
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.