1488154 - move suite s/mime files to suite

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, task)

Description

[Magnus Melin [:mkmelin]]

There are a couple of files + the packaging of s/mimie that are placed in mailnews but are suite only. This is very confusing, so I want to move those to suite/.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1488154_suite_smime.patch

Didn't test suite/, I understand that's not possible atm. This is pretty much what you'd have though I think.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: bug1488154_suite_smime_v2.patch

Thanks for doing this. Stumbled over it recently in Bug 1468079 and already thought about moving it. 

Next step would be to get rid of the copy and use only one implementation but that can wait. We are broken anyway and SeaMonkey won't work anytime soon from comm-central.

You missed the overlay files. They are broken anyway for now but I moved them over 1:1 and built Thundebird to check. As far as I see it they are unused in TB.

The moz.build in extensions needed smine enclosed in brackets.

SeaMonkey builds fine with the above rebased patch. Please check it and if ok check it in. I suspect jorg will want to do it. r+ given.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9006043 [details] [diff] [review]
bug1488154_suite_smime_v2.patch

Review of attachment 9006043 [details] [diff] [review]:
-----------------------------------------------------------------

Even better, thx!

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9006043 [details] [diff] [review]
bug1488154_suite_smime_v2.patch

Review of attachment 9006043 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/extensions/smime/jar.mn
@@ +6,5 @@
>  % content messenger-smime %content/messenger-smime/
>  % overlay chrome://messenger/content/messengercompose/messengercompose.xul     chrome://messenger-smime/content/msgCompSMIMEOverlay.xul
>  % overlay chrome://messenger/content/msgHdrViewOverlay.xul                     chrome://messenger-smime/content/msgHdrViewSMIMEOverlay.xul
>  % overlay chrome://messenger/content/mailWindowOverlay.xul                     chrome://messenger-smime/content/msgReadSMIMEOverlay.xul
> +*  content/messenger/am-smime.xul                                   (../../../mailnews/extensions/smime/content/am-smime.xul)

Any reason for changing the indentation from 4 to 3 spaces?? I'll fix it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/453809366b2d
move suite s/mime files to suite/. r=frg