Closed Bug 1488291 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 12816 - [css-grid] Performance optimizations in the Baseline alignment code

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12816 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12816 Details from upstream follow. Javier Fernandez <jfernandez@igalia.com> wrote: > [css-grid] Performance optimizations in the Baseline alignment code > > Since we integrated the baseline alignment logic in the grid tracks > sizing algorithm, its impact on performance has grown considerably. > > The analysis of the new logic added and its overhead, due to different > operations, shows that evaluating the item's participation in the > baseline alignment context is the most expensive one. It's specially > demanding the evaluation of the grid item's alignment properties. > > Considering that currently we are doing this for every grid item, this > CL propose to reuse the loop we already have to clear the grid item's > override size to cache the items with a baseline value in their > alignment CSS properties. > > Thanks to this cache we can determine the item's participation in a > baseline alignment context in the different phases of the track sizing > algorithm, with almost no cost (compared to the current logic). > > Additionally, this cache is also used in the alignment phase of the > grid layout logic; this change helps to avoid the various issues we > have been suffering related to the different evaluations of the item's > participation in baseline during the different phases of the grid > layout algorithm. > > BUG = 873452 > > Change-Id: Ida27be11ae0f5c455e6077367a277981ab35cec1 > > Reviewed-on: https://chromium-review.googlesource.com/1179897 > WPT-Export-Revision: a770fcf490cc000744e0e801c78c601ea1fd6825
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 45 tests and 126 subtests OK : 45 PASS : 80 FAIL : 46 New tests that have failures or other problems: /css/css-grid/alignment/grid-alignment-style-changes-001.html .after 4: FAIL .before 1: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-002.html .after 4: FAIL .after 6: FAIL .before 1: FAIL /css/css-grid/alignment/grid-alignment-style-changes-003.html .after 4: FAIL .after 6: FAIL .before 1: FAIL .before 2: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-004.html .after 4: FAIL .after 5: FAIL .after 6: FAIL .before 1: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-005.html .after 4: FAIL .after 5: FAIL .after 6: FAIL .before 1: FAIL .before 2: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-006.html .after 4: FAIL .after 5: FAIL .after 6: FAIL .before 1: FAIL .before 2: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-007.html .after 4: FAIL .after 5: FAIL .after 6: FAIL .before 1: FAIL .before 2: FAIL .before 3: FAIL /css/css-grid/alignment/grid-alignment-style-changes-008.html .after 4: FAIL .after 5: FAIL .after 6: FAIL .before 1: FAIL .before 2: FAIL .before 3: FAIL /css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html .grid 1: FAIL .grid 2: FAIL .grid 3: FAIL .grid 4: FAIL .grid 5: FAIL .grid 6: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/557a989b9ef7 [wpt PR 12816] - [css-grid] Performance optimizations in the Baseline alignment code, a=testonly
https://hg.mozilla.org/mozilla-central/rev/557a989b9ef7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.