1488294 - WebRender doesn't infer the color for groove / ridge borders

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: t5.html

And we just paint black, unlike other browsers. This is causing some new reftests to fail with the patch from bug 1487407, since I made collapsed borders go through the same code path as Gecko, which now does infer the color.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Also happens for ridge.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'll take this if nobody wins me, I've seen the related code around today.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Add reftests for groove / ridge borders with default colors.

Note that they are negative (!=) tests. Also note that they don't run because
bug 1488472. I'm fixing that as well, will ensure that's fixed before this
lands.

Comment 4

[Aria Beingessner [:Gankra]]

Just to be clear, we're not talking about teaching wr itself how to infer these colors, but rather the mapping from gecko to wr? (e.g. servo wouldn't get this for free)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to Alexis Beingessner [:Gankro] from comment #4)
> Just to be clear, we're not talking about teaching wr itself how to infer
> these colors, but rather the mapping from gecko to wr? (e.g. servo wouldn't
> get this for free)

WR already inferred these colors for inset / outset, so I thought it to do the same for these other borders.

Comment 6

[Aria Beingessner [:Gankra]]

Ah ok, didn't know we went forward with that.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9006289 [details]
Add reftests for groove / ridge borders with default colors.

Jeff Muizelaar [:jrmuizel] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7251e4f4d2a4
Add reftests for groove / ridge borders with default colors. r=jrmuizel

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/668a74f1fa8c
Update the wpt-manifest since Phabricator keeps landing it as a binary.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12904 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7251e4f4d2a4
https://hg.mozilla.org/mozilla-central/rev/668a74f1fa8c

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged