1488327 - Use new ADBDevice.reverse in Raptor

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement)

Description

[Bob Clary [:bc] (inactive)]

https://searchfox.org/mozilla-central/source/testing/raptor/raptor/raptor.py uses adb reverse in two locations which could be replaced with the new reverse method in ADBDevice.

You will also need to update the requirements in https://searchfox.org/mozilla-central/source/testing/raptor/requirements.txt to make sure you pull in the updated version of mozdevice.

We will need to make sure that the new version of mozdevice from bug 1484238 is published before landing this change to Raptor.

In addition, the current code does not remove the reverses when the script terminates. We should make sure to remove the reverses when the script terminates either normally or abnormally so that we do not leave them polluting the socket connections.

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1488327 - Use new ADBDevice.reverse in Raptor r?rwood

Changed two occurrences of _cmd['reverse', port, port] to use the create_socket_connection method from 1484238.
Added code at end of clean_up() to remove opened socket connections.

Checked via manual execution of raptor-speedometer that opened reverse socket connections are removed at conclusion of test.

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 9007288 [details]
Bug 1488327 - Use new ADBDevice.reverse in Raptor r?rwood

Robert Wood [:rwood] has approved the revision.

Comment 3

[Robert Wood [:rwood]]

Before landing, please push to try and run 1 raptor desktop test just to ensure the linting and raptor unit tests pass. We can't really test the adb reverse itself since we haven't landed raptor geckoview support in production *yet*. Thanks!

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

Try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f067059f427cb73c63e42196c6d23cd2d18a07ca

Comment 5

[Robert Wood [:rwood]]

Great thanks :egao, lando it! :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b57dad790b78
Use new ADBDevice.reverse in Raptor r=rwood

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b57dad790b78