Closed Bug 1488327 Opened Last year Closed Last year

Use new ADBDevice.reverse in Raptor

Categories

(Testing :: Raptor, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: bc, Assigned: egao)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/testing/raptor/raptor/raptor.py uses adb reverse in two locations which could be replaced with the new reverse method in ADBDevice.

You will also need to update the requirements in https://searchfox.org/mozilla-central/source/testing/raptor/requirements.txt to make sure you pull in the updated version of mozdevice.

We will need to make sure that the new version of mozdevice from bug 1484238 is published before landing this change to Raptor.

In addition, the current code does not remove the reverses when the script terminates. We should make sure to remove the reverses when the script terminates either normally or abnormally so that we do not leave them polluting the socket connections.
Assignee: nobody → egao
Blocks: 1473078
Changed two occurrences of _cmd['reverse', port, port] to use the create_socket_connection method from 1484238.
Added code at end of clean_up() to remove opened socket connections.

Checked via manual execution of raptor-speedometer that opened reverse socket connections are removed at conclusion of test.
Comment on attachment 9007288 [details]
Bug 1488327 - Use new ADBDevice.reverse in Raptor r?rwood

Robert Wood [:rwood] has approved the revision.
Attachment #9007288 - Flags: review+
Before landing, please push to try and run 1 raptor desktop test just to ensure the linting and raptor unit tests pass. We can't really test the adb reverse itself since we haven't landed raptor geckoview support in production *yet*. Thanks!
Flags: needinfo?(egao)
Great thanks :egao, lando it! :)
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b57dad790b78
Use new ADBDevice.reverse in Raptor r=rwood
https://hg.mozilla.org/mozilla-central/rev/b57dad790b78
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.